Skip to content

Enforce final newline for json files#95

Open
andrewmumblebee wants to merge 1 commit into
mainfrom
every-file-has-value
Open

Enforce final newline for json files#95
andrewmumblebee wants to merge 1 commit into
mainfrom
every-file-has-value

Conversation

@andrewmumblebee

@andrewmumblebee andrewmumblebee commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

📋 Summary

Every file has value, they all deserve a terminating newline


🔍 Scope of change

  • Documentation only
  • Repository metadata or configuration
  • CI / automation
  • Other (please describe): formatting

📚 Checklist

Summary by CodeRabbit

  • Style
    • Standardized file formatting by removing trailing whitespace and ensuring files end with a final newline.
    • Applied consistent formatting rules across supported file types.

@andrewmumblebee andrewmumblebee requested review from a team, JRoseDev and adamkinniburgh July 16, 2026 14:43
@github-actions

Copy link
Copy Markdown

🧩 Plugin PR Summary

ℹ️ No plugins were modified in this PR.

@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: 305024a9-be9b-40f1-97e6-af1e6c5b5b15

📥 Commits

Reviewing files that changed from the base of the PR and between 9dafcf7 and 259e596.

📒 Files selected for processing (1)
  • .editorconfig

📝 Walkthrough

Walkthrough

.editorconfig now consistently trims trailing whitespace and inserts final newlines, while retaining four-space indentation for supported file types and removing the JSON-specific exception.

Changes

Formatting defaults

Layer / File(s) Summary
EditorConfig rule updates
.editorconfig
Global trailing-whitespace and final-newline settings remain enabled, four-space indentation is retained, and the JSON-specific final-newline override is removed.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the formatting change to enforce final newlines for JSON files.
Description check ✅ Passed The description includes summary, scope, and checklist, so it is mostly complete for the miscellaneous-change template.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@JRoseDev JRoseDev left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants