Recommend script files for errorHandling scripts in the build-plugin skill#92
Open
andrewmumblebee wants to merge 2 commits into
Open
Recommend script files for errorHandling scripts in the build-plugin skill#92andrewmumblebee wants to merge 2 commits into
andrewmumblebee wants to merge 2 commits into
Conversation
The build-plugin skill only showed errorHandling scripts inline in the stream JSON, which gets unreadable beyond a one-liner. The deploy pipeline resolves errorHandling.script file references from dataStreams/scripts/ exactly like postRequestScript, so the skill now documents that form, shows the errorHandling/ sub-folder in the scaffold layout, and cross-links it from the post-request script wiring section. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI (base), Organization UI (inherited) Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe documentation updates define error-handling scripts as ChangesError-handling script file guidance
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
The section still hinted that inlining the script in the stream JSON was fine for trivial one-liners, so agents kept inlining. Script files are easier to review, so the exemption goes: the intro example now shows the file-reference form and the wording that offered inline as an option is removed, along with the wiring example that duplicated the intro. No new guidance added. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
🧩 Plugin PR Summaryℹ️ No plugins were modified in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 Summary
The build-plugin skill only showed
errorHandlingscripts written inline in the stream JSON, which becomes unreadable beyond a one-liner. The deploy pipeline resolveserrorHandling.scriptfile references fromdataStreams/scripts/using exactly the same mechanism aspostRequestScript(it's one of the two registereddataStreamScriptPaths, and plugin export already writes to anerrorHandling/sub-folder), so the skill now documents that form — and only that form, since script files are easier to review than inline JSON strings:references/data-streams.mdshows the file-reference form as the way to write a script (dataStreams/scripts/errorHandling/<streamName>.js), with a "Script files" subsection covering the reference-resolution rules (bare.jspath marks a reference, deploy inlines the source, unresolvable references fail validation,{{ ... }}expressions work in script files too) and a script-file example. No inline example remains.SKILL.mdshows thescripts/errorHandling/sub-folder.🔍 Scope of change
📚 Checklist
🤖 Generated with Claude Code
Summary by CodeRabbit
errorHandling/script directory..jsextensions.