Fix issue #237 - Incorrect usage of return value in flash_file method#263
Merged
hkpeprah merged 2 commits intoMar 13, 2026
Merged
Conversation
JLINK_DownloadFile from JLINK's DLL does not return number of bytes flashed. It returns error code
|
|
TheColector
changed the title
Contributor
|
LGTM. You just have to sign the CLA for us to accept this change though. |
Contributor
Author
|
It's already been signed on my end. |
TheColector
force-pushed
the
fix/ISSUE-237/fix_flash_file_method_return
branch
from
March 12, 2026 10:12
ffa6506 to
8900a85
Compare
hkpeprah
self-requested a review
March 13, 2026 16:39
Contributor
|
Will release this with the other change for the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue mentioned by me in #237