ci: separate package and test Python versions - #536
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ef963ebfcd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8b3069323e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| test-python-version: | ||
| required: false | ||
| description: "Python version to use for WFE test tooling and test dependencies; defaults to python-version" | ||
| type: string | ||
| default: "" |
There was a problem hiding this comment.
Document the split Python inputs
Callers consulting the reusable-workflow specification still see only python-version described as the version used for testing (README.md:191), while this new input is absent. As a result, users cannot discover how to select a newer WFE tooling interpreter without also changing the package-build interpreter; update the README to describe both inputs and their fallback relationship.
Useful? React with 👍 / 👎.
Summary
Separates the interpreter used to build an add-on package from the interpreter used by WFE test tooling.
python-versionfor package build and pre-commit (default: Python 3.9).test-python-versionfor test dependency setup and all WFE test-runner invocations (default: Python 3.9).Validation
ruby -e "require \"yaml\"; YAML.load_file(...)"passed.git diff --checkpassed.Related: splunk/splunk-add-on-for-microsoft-office-365#1018