Skip to content

ci: separate package and test Python versions - #536

Open
rasteja wants to merge 2 commits into
developfrom
feat/separate-test-python-version
Open

ci: separate package and test Python versions#536
rasteja wants to merge 2 commits into
developfrom
feat/separate-test-python-version

Conversation

@rasteja

@rasteja rasteja commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Summary

Separates the interpreter used to build an add-on package from the interpreter used by WFE test tooling.

  • Keeps python-version for package build and pre-commit (default: Python 3.9).
  • Adds test-python-version for test dependency setup and all WFE test-runner invocations (default: Python 3.9).
  • Allows add-ons such as O365 to package for Splunk 9.4/10.0 with Python 3.9 while running PSA/SmartX/UCC 3.0 test tooling on Python 3.13.

Validation

  • ruby -e "require \"yaml\"; YAML.load_file(...)" passed.
  • git diff --check passed.

Related: splunk/splunk-add-on-for-microsoft-office-365#1018

@rasteja
rasteja requested a review from a team as a code owner August 26, 2026 07:22

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ef963ebfcd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/reusable-build-test-release.yml Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8b3069323e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +65 to +69
test-python-version:
required: false
description: "Python version to use for WFE test tooling and test dependencies; defaults to python-version"
type: string
default: ""

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Document the split Python inputs

Callers consulting the reusable-workflow specification still see only python-version described as the version used for testing (README.md:191), while this new input is absent. As a result, users cannot discover how to select a newer WFE tooling interpreter without also changing the package-build interpreter; update the README to describe both inputs and their fallback relationship.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant