fix(webpack): update playlist menu needle for Spotify 1.2.99+ - #9
Open
Mralimoh wants to merge 1 commit into
Open
fix(webpack): update playlist menu needle for Spotify 1.2.99+#9Mralimoh wants to merge 1 commit into
Mralimoh wants to merge 1 commit into
Conversation
Updated the needle for playlist menu module ID to match Spotify 1.2.99 capabilities.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
[stdlib] webpack needle miss: value:"playlist" + canView + permissionswarning on Spotify1.2.99+builds and restoresMenus.Playlist.Context & Root Cause
In Spotify
1.2.99.317(and newer):value:"playlist"no longer exists as an inline string literal in any module factory; the playlist type enum was hoisted into a shared enum module (module4464) and is accessed via member reference (type: rz.c.PLAYLIST).84828) producescanViewandcanPin, whereaspermissionsis consumed downstream in module3046. The old triple co-occurrence is broken.Fix
Replaced the dead needle predicate with a regex anchoring on stable, unmangled adjacent capability properties (
canPin+canView) which uniquely identifies the playlist mapper module (84828).