Skip to content

Introduce format-assertion 2020-12 and 2019-09 dialects#94

Merged
jviotti merged 1 commit into
mainfrom
format-assertion-dialect
Jul 15, 2026
Merged

Introduce format-assertion 2020-12 and 2019-09 dialects#94
jviotti merged 1 commit into
mainfrom
format-assertion-dialect

Conversation

@jviotti

@jviotti jviotti commented Jul 15, 2026

Copy link
Copy Markdown
Member

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Review in cubic

@augmentcode

augmentcode Bot commented Jul 15, 2026

Copy link
Copy Markdown
🤖 Augment PR Summary

Summary: This PR introduces “format-assertion” dialect meta-schemas for JSON Schema 2019-09 and 2020-12.

Changes:

  • Added README entries linking to the JSON Schema 2019-09 and 2020-12 specifications
  • Added a 2019-09 dialect meta-schema intended to treat format as an assertion
  • Added a 2020-12 dialect meta-schema that enables the official format-assertion vocabulary
  • Added test fixtures for both dialect meta-schemas to validate accepted/rejected schema shapes

Technical Notes: The new dialect files are expressed as JSON Schema resources with $vocabulary declarations and delegate structural validation via $ref to the corresponding upstream draft meta-schemas.

🤖 Was this summary useful? React with 👍 or 👎

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestion posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

"https://json-schema.org/draft/2019-09/vocab/applicator": true,
"https://json-schema.org/draft/2019-09/vocab/validation": true,
"https://json-schema.org/draft/2019-09/vocab/meta-data": true,
"https://json-schema.org/draft/2019-09/vocab/format": true,

@augmentcode augmentcode Bot Jul 15, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

schemas/2020-12/ietf/jsonschema/2019-09/dialect/format-assertion.json:8: This dialect is described as making format an assertion, but the 2019-09 https://json-schema.org/draft/2019-09/vocab/format vocabulary defines format as an annotation (the true/false here only indicates required vs optional vocabulary support). As written, this dialect mainly flips the official 2019-09 meta-schema’s format vocabulary from false to true, which may not actually provide “assertion” semantics to consumers.

Severity: medium

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

@jviotti jviotti force-pushed the format-assertion-dialect branch 2 times, most recently from f39ccbd to bdbb523 Compare July 15, 2026 18:02

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed against the latest diff

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread README.markdown Outdated
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@jviotti jviotti force-pushed the format-assertion-dialect branch from bdbb523 to eeeff51 Compare July 15, 2026 18:08
@jviotti jviotti merged commit a11ab84 into main Jul 15, 2026
2 checks passed
@jviotti jviotti deleted the format-assertion-dialect branch July 15, 2026 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant