Clearly separate literals and patterns in the test DSL

[jviotti]

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

[augmentcode]

🤖 Augment PR Summary

Summary: This PR refines the internal CLI-test DSL by separating literal filters from regular-expression filters.

Changes:

• Makes REPLACE use literal text by default.
• Adds REPLACE MATCHING for regex substitution.
• Adds DROP LINES CONTAINING while retaining regex-based DROP LINES MATCHING.
• Moves regex compilation and validation into a dedicated helper.
• Keeps replacement operands literal and variable-expandable.
• Migrates path, hash, and JSON-output fixtures to literal filter forms.
• Migrates benchmark normalisation fixtures to the explicit regex form.

Technical Notes: Patterns now compile in multiline mode and are intended not to expand variables; the fixture updates remove regex escaping where literal matching is sufficient.

_{🤖 Was this summary useful? React with 👍 or 👎}

[augmentcode]

Review completed. 1 suggestion posted.

Comment augment review to trigger a new review at any time.

[augmentcode]

compile_pattern is documented as receiving patterns verbatim, but VARIABLE.search also matches an escaped regex dollar. For example, REPLACE MATCHING '^\s*"\$schema":' ... is rejected as a variable reference, so regex filters cannot match common JSON Schema $-prefixed keywords (nor use $$).

Severity: medium

_{🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.}

[cubic-dev-ai]

1 issue found across 76 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="scripts/clitest.py">

<violation number="1" location="scripts/clitest.py:289">
P2: The existing help tests still pass `\\.exe` expecting regex removal. This literal branch leaves `jsonschema.exe` unchanged on Windows, so those tests fail; migrate those callers or preserve compatibility.</violation>
</file>

<sub>Reply with feedback, questions, or to request a fix.

Re-trigger cubic</sub>

[cubic-dev-ai]

P2: The existing help tests still pass \\.exe expecting regex removal. This literal branch leaves jsonschema.exe unchanged on Windows, so those tests fail; migrate those callers or preserve compatibility.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At scripts/clitest.py, line 289:

<comment>The existing help tests still pass `\\.exe` expecting regex removal. This literal branch leaves `jsonschema.exe` unchanged on Windows, so those tests fail; migrate those callers or preserve compatibility.</comment>

<file context>
@@ -256,33 +267,50 @@ def command_compare(self, operands, line_number):
-                self.expand(replacement, line_number).replace("\\", "\\\\"), content)
+        expanded = self.expand(replacement, line_number)
+        if expression is None:
+            content = content.replace(
+                self.expand(operands[0], line_number), expanded)
         else:
</file context>

[cubic-dev-ai]

All reported issues were addressed across 1 file (changes from recent commits).

<sub>Reply with feedback, questions, or to request a fix.

Re-trigger cubic</sub>