Conversation
Signed-off-by: Sacha Ayoun <sachaayoun@gmail.com>
Replace the Buffer/Printf-based renderers with Format-based Fmt printers: - Ast: const_repr -> recursive pp_const; render_generic -> pp_code_generic (no rstrip; the bytecode instruction column simply emits no trailing pad). - Phir: instr_str/value_str/var_str -> pp_instr/pp_value/pp_var; pp_code delegates to Ast.pp_code_generic. instr_to_string is now derived. - Add fmt as a dependency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a GitHub Actions workflow that runs the full test suite on every PR and push to
main.The workflow (
.github/workflows/ci.yml) runs, onubuntu-latest:dune builddune build @fmt— formatting check (ocamlformat 0.29.0, pinned in.ocamlformat)dune runtest— golden expect-testsdune build @stdlib @interp @gen— the acceptance gates (stdlib sweep, differential interpreter, opcode-gen drift)It pins CPython 3.13.5 (the version the goldens were generated with) and exposes it via
PYTECODE_PYTHON, plus ensurespython3.13is onPATHfor the@genrule.Note
This branch also includes the prior commit "Rewrite Ast/Phir pretty-printers with Fmt" (working-tree changes that were not yet committed), so CI validates the actual current code. Happy to split it out if you'd prefer a CI-only PR.