VertexSeq, SimpleWalk/Path/Cycle, girth related stuff - #13
Open
yzll0 wants to merge 3 commits into
Open
Conversation
sorrachai
reviewed
Jul 2, 2026
| /-! ## reroot -/ | ||
|
|
||
| /-- Re-root a simple cycle at any vertex on it. -/ | ||
| def reroot [DecidableEq α] (c : SimpleCycle α) (u : α) (hu : u ∈ vertices c) : |
Owner
There was a problem hiding this comment.
The definition looks super complicated. Is there a way to simplify or split the subclaims outside?
Collaborator
Author
There was a problem hiding this comment.
It's because the proof that rerooting a cycle yields a cycle is long. I'll separate it as a lemma.
yzll0
changed the title
yzll0
changed the title
yzll0
force-pushed
the
codex/graphlib-structures-refactor
branch
from
July 13, 2026 15:40
251cbbe to
c58b09f
Compare
Owner
|
Looks good to me overall. Any other concerns? |
Owner
|
@BasilRohner I would like to merge this one soon. Do you have more comments? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add GraphLib/Graph/Adjacency.lean; split GraphLib/Theory/Structures/VertexSeq.lean into many subfiles.
SimpleWalk.lean, SimplePath.lean, SimpleCycle.lean, InSimpleGraph.lean, InSimpleDiGraph.lean