feat: newsletter GDPR deletion, rate-limit UX, e2e lifecycle tests, and global ErrorBoundary - #1431
Open
Mystery-CLI wants to merge 4 commits into
Open
Conversation
…nsubscribe/GDPR flows (solutions-plug#1406)
|
@Mystery-CLI Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR resolves four backlog tasks across the Newsletter and Resilience areas:
1. #1404 — GDPR Data Deletion Request Page
/account/privacy/deletepage (frontend/src/app/account/privacy/delete/page.tsx).DELETE MY DATA PERMANENTLY.data-lpignore,data-1p-ignore,autoComplete="off",spellCheck={false}) to ensure deliberate manual confirmation.api.newsletterGdprDeletewith accessible alert handling for error/success states.2. #1405 — Rate-Limit-Aware UX for Newsletter Subscribe
frontend/src/components/NewsletterSignup.tsxand refactoredLandingPage.tsxto use it.3. #1406 — E2E Coverage for Newsletter Lifecycle & GDPR Flows
frontend/e2e/newsletter.spec.tscovering the full end-to-end lifecycle:subscribe→confirm→GDPR export→GDPR delete(modal & phrase confirmation) →unsubscribe.afterEacheven on assertion failure to prevent staging list pollution.e2e/newsletter.spec.tstoMOCKED_SPECSinfrontend/playwright.config.ts.4. #1407 — Recreate Global ErrorBoundary
frontend/src/components/ErrorBoundary.tsxwith reload page action, report issue link/action, and resilient fallback UI.frontend/src/components/__tests__/LandingPage.error-boundary.test.tsxwith unit tests for global error catching, fallback rendering, report action, andonErrorcallback dispatch.Closes #1404
Closes #1405
Closes #1406
Closes #1407