Analysis server migration

.github/workflows/flutter.yaml

@@ -6,7 +6,7 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v7
 
       - name: Setup Flutter
         uses: subosito/flutter-action@v2
@@ -24,17 +24,14 @@ jobs:
         run: dart format . --set-exit-if-changed
 
       - name: Run default analyzer
-        run: flutter analyze
-
-      - name: Run custom analyzer
-        run: dart run custom_lint
+        run: dart analyze
 
       - name: Run tests
         run: |
           # run tests if `test` folder exists
           if [ -d test ]
           then
-              flutter test -r expanded
+              dart test -r expanded
           else
               echo "Tests not found."
           fi

CHANGELOG.md

@@ -1,3 +1,14 @@
+## 1.0.0
+
+- feat!: migrate to analyzer_server_plugin
+- refactor: replace `avoid_unnecessary_type_casts` rule with dart analyzer's
+  `unnecessary_cast`
+- Added `use_nearest_context` rule.
+- Added `avoid_duplicate_code` rule.
+- Added `use_descriptive_names_for_type_parameters` rule.
+- Added `avoid_similar_names` rule.
+- Added `feature_envy` rule.
+
 ## 0.3.3
 
 - Fix pub.dev analysis issue
@@ -11,9 +22,9 @@
 
 - Added `allow_with_comments` parameter for `no_empty_block` lint.
 - Added extension support for `avoid_using_api`
-- Added `exclude_entity` parameter for `prefer_match_file_name` lint.
-  It is now possible to configure this lint to ignore `enum`,
-  `extension` and `mixin` declarations via `analysis_options.yaml`.
+- Added `exclude_entity` parameter for `prefer_match_file_name` lint. It is now
+  possible to configure this lint to ignore `enum`, `extension` and `mixin`
+  declarations via `analysis_options.yaml`.
 
 ## 0.3.0
 
@@ -24,7 +35,8 @@
   - `function_lines_of_code`
   - `no_empty_bloc`
   - `number_of_parameters`
-- BREAKING CHANGE: Renamed `excludeNames` parameter to `exclude` for `function_lines_of_code` lint.
+- BREAKING CHANGE: Renamed `excludeNames` parameter to `exclude` for
+  `function_lines_of_code` lint.
 - Fixed an issue with `prefer_early_retrun` for throw expression
 - `number_of_parameters` lint: added `copyWith` to the default exclude list.
 - Update dependencies:
@@ -47,28 +59,36 @@
 ## 0.2.0
 
 - Added `avoid_final_with_getter` rule
-- Improve `avoid_late_keyword` - `ignored_types` to support ignoring subtype of the node type (<https://github.com/solid-software/solid_lints/issues/157>)
-- Abstract methods should be omitted by `proper_super_calls` (<https://github.com/solid-software/solid_lints/issues/159>)
-- Add a rule prefer_guard_clause for reversing nested if statements (<https://github.com/solid-software/solid_lints/issues/91>)
-- add exclude params support to avoid_returning_widgets rule (<https://github.com/solid-software/solid_lints/issues/131>)
-- add quick fix to avoid_final_with_getter (<https://github.com/solid-software/solid_lints/pull/164>)
+- Improve `avoid_late_keyword` - `ignored_types` to support ignoring subtype of
+  the node type (<https://github.com/solid-software/solid_lints/issues/157>)
+- Abstract methods should be omitted by `proper_super_calls`
+  (<https://github.com/solid-software/solid_lints/issues/159>)
+- Add a rule prefer_guard_clause for reversing nested if statements
+  (<https://github.com/solid-software/solid_lints/issues/91>)
+- add exclude params support to avoid_returning_widgets rule
+  (<https://github.com/solid-software/solid_lints/issues/131>)
+- add quick fix to avoid_final_with_getter
+  (<https://github.com/solid-software/solid_lints/pull/164>)
 - Renamed `avoid_debug_print` to `avoid_debug_print_in_release`
-- The `avoid_debug_print_in_release` no longer reports a warning if the `debugPrint` call is wrapped in a `!kReleaseMode` check.
+- The `avoid_debug_print_in_release` no longer reports a warning if the
+  `debugPrint` call is wrapped in a `!kReleaseMode` check.
 - Update custom_lints to work with newer Flutter
 
 ## 0.1.5
 
 - Added `avoid_debug_print` rule
 - Fixed an issue with no_magic_number lint
-- Fixed `avoid_unused_parameters` to report positional parameters from typedef if their name are not underscores.
+- Fixed `avoid_unused_parameters` to report positional parameters from typedef
+  if their name are not underscores.
 - Improvement for `avoid_returning_widget` lint:
   - ignores methods that override ones that return widget (build() for example)
   - no longer allows returning widgets from methods/functions named build
 - Fixed unexpected avoid_unnecessary_type_assertions
 - Added `excludeNames` param for `function_lines_of_code` lint
 - Improved `avoid_unrelated_type_assertions` to support true and false results
-- Set default `cyclomatic_complexity` to 10 (<https://github.com/solid-software/solid_lints/issues/146>)
-  Credits: Arthur Miranda (<https://github.com/arthurbcd>)
+- Set default `cyclomatic_complexity` to 10
+  (<https://github.com/solid-software/solid_lints/issues/146>) Credits: Arthur
+  Miranda (<https://github.com/arthurbcd>)
 
 ## 0.1.4
 
@@ -102,8 +122,7 @@
   - avoid_unnecessary_type_casts
   - avoid_unrelated_type_assertions
   - avoid_unused_parameters
-  - avoid_using_api
-    Credits: getBoolean (<https://github.com/getBoolean>)
+  - avoid_using_api Credits: getBoolean (<https://github.com/getBoolean>)
   - cyclomatic_complexity
   - double_literal_format
   - function_lines_of_code
@@ -170,7 +189,8 @@
 
 ## 0.0.13
 
-- enable use_colored_box & use_decorated_box + add more comments about specific lints
+- enable use_colored_box & use_decorated_box + add more comments about specific
+  lints
 
 ## 0.0.12
 

README.md

@@ -19,13 +19,26 @@ dev_dependencies:
   solid_lints: <INSERT LATEST VERSION>
 ```
 
-And then include `solid_lints` into your project top-level `analysis_options.yaml`:
+Enable the plugin and include `solid_lints` in your project's top-level `analysis_options.yaml`:
+
+### Option 1: Using the `plugins` block
 
 ```yaml
 include: package:solid_lints/analysis_options.yaml
+
+plugins:
+  solid_lints:
 ```
 
-Also you can use a specialized rule set designed for Dart tests.
+### Option 2: Using the top-level `solid_lints` block
+
+```yaml
+include: package:solid_lints/analysis_options.yaml
+
+solid_lints:
+```
+
+Also, you can use a specialized rule set designed for Dart tests.
 Add an `analysis_options.yaml` file under the `test/` directory, and include the ruleset:
 
 ```yaml
@@ -36,7 +49,34 @@ Then you can see suggestions in your IDE or you can run checks manually:
 
 ```bash
 dart analyze;
-dart run custom_lint;
+```
+
+# Configuration
+
+You can customize individual rule settings in your `analysis_options.yaml`.
+
+### Option 1: Inside the `plugins` block (Recommended)
+
+```yaml
+plugins:
+  solid_lints:
+    diagnostics:
+      cyclomatic_complexity:
+        max_complexity: 10
+      avoid_non_null_assertion: true
+```
+
+### Option 2: Separate top-level `solid_lints` block
+
+```yaml
+plugins:
+  solid_lints:
+
+solid_lints:
+  diagnostics:
+    cyclomatic_complexity:
+      max_complexity: 10
+    avoid_non_null_assertion: true
 ```
 
 # Badge

doc/docusaurus/docs/1_rulesets/test.md

@@ -65,6 +65,12 @@ Given the quite large threshold configured for this metric we considered extract
 
 Both options didn't look right, so we decided that tests are ok to be long.
 
+## cyclomatic_complexity
+
+State: **Disabled**.
+
+Since we're not using the `function_lines_of_code` rule, the `main()` function in tests can have high cyclomatic complexity. For the rationale against splitting up `main()` in tests, see the comments for `function_lines_of_code` above.
+
 ## prefer_match_file_name
 
 State: **Disabled**.

doc/docusaurus/package.json

@@ -16,8 +16,8 @@
     "typecheck": "tsc"
   },
   "dependencies": {
-    "@docusaurus/core": "^3.1.0",
-    "@docusaurus/preset-classic": "^3.1.0",
+    "@docusaurus/core": "^3.10.1",
+    "@docusaurus/preset-classic": "^3.10.1",
     "@easyops-cn/docusaurus-search-local": "^0.40.1",
     "@mdx-js/react": "^3.0.0",
     "clsx": "^2.1.0",