Fix dependent propagation when a project has multiple dependents (by JohnCampionJr) - #32
Merged
Merged
Conversation
GetProjectsDependentsNames added each dependent to its set but then overwrote the entry with a fresh single-element set, so only the last dependent survived. Add to the existing set instead of replacing it.
HashSet iteration order can vary between runs (records hash by value and string hashing is randomized per process), so sort dependents by name when materializing to keep output ordering stable.
* Adopt .NET 10 with multitargeting Multi-target net8.0;net10.0 for the tool and tests, bump the SDK and CI to .NET 10, and run the tests on both runtimes. AnalysisLevel tracks the TFM now; fixed the findings it surfaced (CA1515 -> internal types with InternalsVisibleTo for Moq, CA1872 -> Convert.ToHexString). * Support macOS in ProcessExecutorTests * Relax global.json SDK to a band-agnostic floor Use 10.0.100 with rollForward latestFeature so any installed .NET 10 feature band satisfies it, instead of requiring 10.0.300 or higher. * Simplified lang and analysis version for both .net versions only one lang and analysis should be supported (we will develop in .net 10, yet compile for .net 8-10) * Update target frameworks to include net9.0 * Remove LangVersion condition for net8.0 * Add target frameworks net8.0, net9.0, and net10.0 to directory.build.props * Deleted target frameworks in project file as it was moved to directory.build.props Removed net10.0 from the target frameworks. * Deleted target frameworks in project file as it was moved to directory.build.props * Update .NET version to 10.0.x in CI workflow for building all .net 8-10 we just need the .net 10 sdk * Update adopt-dotnet-10.md --------- Co-authored-by: John Campion Jr <1094820+JohnCampionJr@users.noreply.github.com>
magiino
approved these changes
Jul 10, 2026
This was referenced Jul 10, 2026
Merged
jvilimek
added a commit
that referenced
this pull request
Jul 10, 2026
## 0.2.0 **Minor Changes**: - [[#16](https://github.com/solarwinds/net-changesets/issue/16)] Adopt .NET 10 with multi-targeting. The tool and tests now target `net8.0`, `net9.0` and `net10.0`, the SDK and CI use .NET 10. [[#30](#30)] **Patch Changes**: - [[#28](#28)] Added documentation for integrating net-changesets with the official Changesets GitHub Action, including custom `version` and `publish` commands, required checkout depth, status-check behavior, NuGet source configuration, and links to a working demo workflow. ([PR #29](#29)) - Upgrade Spectre.Console to 0.56.0 and Spectre.Console.Cli to 0.55.0 (with matching testing packages). Adapts to the new command `ExecuteAsync(CommandContext, CancellationToken)` signature and the move of `CommandAppTester` into the new `Spectre.Console.Cli.Testing` package. [[#31](#31)] - Fix `version` only bumping one dependent when a project is referenced by multiple projects. [[#32](#32)]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found this while working on a new feature.
When a project is referenced by more than one other project,
changeset versiononly bumped (and wrote a changelog for) one of those dependents — the last one
processed. GetProjectsDependentsNames added each dependent to its set but then
overwrote the entry with a fresh single-element set, so all but the last were lost.
Added a test with a project that has two dependents, and fixed the lookup to add
to the existing set instead of replacing it.
Co-authored-by: John Campion Jr 1094820+JohnCampionJr@users.noreply.github.com