Various Clippy fixes.#91
Merged
Merged
Conversation
I'm not super keen on `BITS as usize`, but it is clearer than `size_of<...> * 8`, and the alternative is `usize::try_from(iX::BITS).unwrap()` which is objectionable in other ways.
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 16, 2026
Member
Author
|
@ratmice Hopefully this one will go through now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not super keen on
BITS as usize, but it is clearer thansize_of<...> * 8, and the alternative isusize::try_from(iX::BITS).unwrap()which is objectionable in other ways.