Add state tracking for unicode#39
Closed
nanjekyejoannah wants to merge 5 commits into
Closed
Conversation
ltratt
added this pull request to the merge queue
Apr 9, 2024
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Apr 9, 2024
Member
|
@nanjekyejoannah This one failed with errors --- worth fixing? |
nanjekyejoannah
force-pushed
the
warn_unicode_parsing
branch
from
May 1, 2024 12:26
9312ad1 to
507db05
Compare
Collaborator
Author
|
I added a missing attribute and fixed a test. |
ltratt
reviewed
May 1, 2024
| #else | ||
| #endif | ||
|
|
||
| // if (PyUnicode_Check(obj)) { |
Member
There was a problem hiding this comment.
Should we just delete this chunk?
Collaborator
Author
|
Let me first run the whole suite locally myself too. |
Collaborator
Author
|
Fixing this bug, uncovered that it is related to us adding |
Collaborator
Author
|
Lets figure out tracking in before we get back here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just state, warning already existed.
Format methods are shared, so warnings are covered in #38