Skip to content

packedvec-2.0.0#44

Merged
ratmice merged 2 commits into
softdevteam:masterfrom
ltratt:packedvec_2_0_0
Jul 16, 2026
Merged

packedvec-2.0.0#44
ratmice merged 2 commits into
softdevteam:masterfrom
ltratt:packedvec_2_0_0

Conversation

@ltratt

@ltratt ltratt commented Jul 16, 2026

Copy link
Copy Markdown
Member

@ratmice I'd welcome your opinions here. On reflection I think we have no choice in this crate but to do a major semver bump, at which point updating the feature name seems worth the pain. I can be persuaded otherwise on both points though!

I umed and ahed on this one, but once it became clear to me that we have
to make a major semver bump anyway, renaming the feature seemed the
right thing to do at the same time.
@ratmice

ratmice commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

I think it's probably the right call, I do wonder because cargo lacks a way to deprecate features,
we could roll our own deprecation:

#[cfg(feature = "bincode")]
compile_error!("the bincode feature has been deprecated in favor of the 'wincode' feature");

Sadly this comes with some downsides:

  1. We'd have to add the feature back to Cargo.toml minus the dep:wincode
  2. In that the feature would probably still show up in the docs.rs feature list.

But it would make for a nicer error when people just bump the version.
I'm torn on whether that is worthwhile, or whether to just remove the feature outright like you did.

@ltratt

ltratt commented Jul 16, 2026

Copy link
Copy Markdown
Member Author

Because packedvec has few dependents -- and my guess is only grmtools uses the bincode dependency -- I think we can cross our fingers and hope the rename doesn't hurt anyone in practise. If it does turn out to cause other people issues, we could do a 2.0.1 where we add a feature like the above?

@ratmice

ratmice commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

Seems reasonable enough, but lets put a note in the CHANGES.md that the feature was renamed.

@ltratt ltratt force-pushed the packedvec_2_0_0 branch from 5f51cad to ba2123c Compare July 16, 2026 08:16
@ltratt

ltratt commented Jul 16, 2026

Copy link
Copy Markdown
Member Author

Good point! Fixed in the force push.

@ratmice ratmice added this pull request to the merge queue Jul 16, 2026
Merged via the queue into softdevteam:master with commit 69cc850 Jul 16, 2026
2 checks passed
@ltratt ltratt deleted the packedvec_2_0_0 branch July 16, 2026 08:21
@ltratt

ltratt commented Jul 16, 2026

Copy link
Copy Markdown
Member Author

@ratmice This should now be live on crates.io.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants