[DRAFT] feature: use schema extensions for JSON and CBOR naming - #353
Draft
jterapin wants to merge 11 commits into
Draft
[DRAFT] feature: use schema extensions for JSON and CBOR naming#353jterapin wants to merge 11 commits into
jterapin wants to merge 11 commits into
Conversation
jterapin
force-pushed
the
schema-extensions
branch
from
August 19, 2026 22:52
ca43cbb to
3cd9d5b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previous PR added a stopgap reverse map on
StructureShapekeyed by bothlocation_nameandjsonName. That made member resolution protocol-blind: ajsonNamewire key could resolve even when the protocol should use the model member name instead. This PR replaces that stopgap with lazy, per-protocol wire-name resolution for JSON and CBOR.Base branch:
serde-data-drivenDescription
This PR removes the global reverse-map approach and moves wire-name resolution into the JSON and CBOR serde paths.
Highlights:
jsonNameis now resolved only when the protocol actually uses it.MemberShapenow usesmodel_nameas the primary modeled member identity.model_name:and symbolized serde trait keys for the JSON/CBOR paths.Behavior after this change:
json_name: trueusesjsonNamejson_name: falseuses the model member nameThis keeps the fix focused: no Query/XML behavior changes are being introduced here.
Other Notes
MemberShape#initializestill falls back frommodel_name:tolocation_name:for downstream compatibility.location_name:.member_by_wire_namepath is removed.__typebehavior is preserved only when it is explicitly modeled throughjsonName.Testing
Passed all specs.