Expectation slight rework - #14
Merged
Merged
Conversation
Goal is to remove chaining calls on Expect Migrated Not, Mandatory and OnErrorExtra to optional field for Expect. Deprecated older calls. Made ToBeXXX calls to return ExpectationResult instead of Expectation Changed pass value to return the expectation success, taking inverted into account. No need to check if expectation is inverted anymore. Update unit tests Update documentation
Change mandatory to policy to fine tune error management Added consumed flag, to prevent retesting an expectation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle requirements from expect-opt-extension.md
Goal is to remove chaining calls on Expect, to avoid odd behavior.
matchers(ToBeXXX) calls to return ExpectationResult instead of Expectationmatchersto "consume" expectation, to prevent having multiple expectation with same ID/NameNotes