Skip to content

feat(cli): surface crew-vs-platform config ownership (init + doctor) [5.7.0] - #91

Closed
abhishekmishragithub wants to merge 1 commit into
mainfrom
feat/crew-config-ownership
Closed

feat(cli): surface crew-vs-platform config ownership (init + doctor) [5.7.0]#91
abhishekmishragithub wants to merge 1 commit into
mainfrom
feat/crew-config-ownership

Conversation

@abhishekmishragithub

Copy link
Copy Markdown
Collaborator

Surfaces the crew ownership boundary in the SDK/CLI, off a real customer confusion (a crew agent with transfer_call toggled in the dashboard + PII redaction on).

What

  • Shared ownership matrix (cli/lib/ownership.py): a crew owns only the LLM turn (prompt, messages, @function_tools, end/transfer/speak/mute); the platform owns voice/STT/PII redaction/first-message/timeouts, read fresh per call.
  • agent-crew init prints the ownership summary after linking.
  • New agent-crew doctor [--agent-id] — inspects an agent and flags: no live crew build, non-single_prompt workflow, PII redaction ON (rewrites the transcript), and transfer_call enabled in the dashboard Tools panel (inert for crew agents).
  • Deprecates SDKSystemUpdateOutputAgentSettingsEvent (emits DeprecationWarning) — the platform never applies crew-sent output-agent settings; removal in a future release.

Verified

  • doctor run live against a real agent: correctly flagged "PII redaction is ON" and confirmed the live build.
  • pytest tests/custom — 101 passed, 1 skipped (no regressions); new test_crew_ownership_cli.py = 3 passed.
  • mypy: new files clean. (Two pre-existing mypy warnings in the builds command are unrelated and present on main.)

Notes for review

  • Version set to 5.7.0 assuming the adapters PR (feat(integrations): optional pipecat + livekit adapters (5.6.0) #90, 5.6.0) merges first; adjust if merge order differs.
  • Docs counterpart: smallest-ai-documentation#363. Canonical matrix: AGENT_SDK_OWNERSHIP.md.
  • Deferred from Sauron's Prompt 1: the deploy pre-flight lint (heuristic scan of user code) — left out to avoid false positives; doctor covers the same ground more reliably.

Draft — merging bumps the version and auto-publishes. Hold for your review.

Make the crew ownership boundary obvious in the SDK/CLI, off the back of a real
customer confusion (dashboard tools + redaction on a crew agent).

- New shared ownership matrix (cli/lib/ownership.py): crew owns only the LLM turn;
  platform owns voice/STT/redaction/first-message/timeouts, read fresh per call.
- `agent-crew init` prints the ownership summary after linking.
- New `agent-crew doctor [--agent-id]`: flags no-live-build, non-single_prompt
  workflow, PII redaction ON, and dashboard Tools transfer_call (inert for crew).
  Verified live: correctly flags redaction ON + confirms the live build.
- Deprecate SDKSystemUpdateOutputAgentSettingsEvent (not applied by the platform;
  emits DeprecationWarning, removal in a future release).

Docs counterpart shipped separately. Version 5.7.0.
@abhishekmishragithub

Copy link
Copy Markdown
Collaborator Author

Superseded by the consolidated release PR release/5.10.0 (single review + single version bump). Branch kept.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant