fix: include subscribed thread unreads and mentions in counts - #4
Merged
Conversation
Thread data from client.counts was decoded but never used — the threads.hasUnreads/mentionCount fields were ignored and channelBadges were discarded. Wire thread data through the full pipeline: new .thread ConversationType, AggregatedCounts fields, menu bar display, and section grouping.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
client.countsAPI already returns thread data (threads.hasUnreads,threads.mentionCount,channelBadges.threadMentions), butpollWorkspace()discarded it entirely. Now thread counts are extracted, aggregated, and displayed.text.bubbleSF Symbol, consistent with the inline icon approach from the sidebar sections feature.Changes
StateStore.swift.threadconversation type, thread extraction inpollWorkspace(), thread handling ingroupBySections()andfallbackGrouping()SlackStatApp.swift.threadcase withtext.bubbleSF SymbolMenuBarTitle.swiftVersion.swift0.1.0→0.2.0StateStoreTests.swiftTesting