feat: add sidebar sections and inline channel icons to menu bar dropdown - #3
Merged
Merged
Conversation
Mirror Slack's sidebar organization with proper section headers (Mentions, Team, Channels, External Connections, Direct Messages). Use three-pass grouping: mentions first, then explicit user-created sections, then virtual catch-all sections based on channel characteristics. Replace text prefixes with inline SF Symbol icons via NSTextAttachment — lock icon for private channels, # for public — avoiding the image column padding from NSMenuItem.image. Right-align relative timestamps using NSParagraphStyle tab stops. Add users.channelSections.list API endpoint, isPrivate/isExtShared fields on ConversationInfo and ConversationItem, and NameCache entries for both. Includes 6 new tests (39 total).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#, both rendered as SF Symbol icons viaNSTextAttachmentto avoid the image-column padding thatNSMenuItem.imagecauses.NSParagraphStyletab stops and dimmed withsecondaryLabelColor.users.channelSections.listto fetch sidebar sections, withclient.userBootas fallback.isPrivateandisExtSharedfields onConversationInfoandConversationItem, with correspondingNameCacheentries.Changes
SlackModels.swiftisPrivate,isGroup,isExtSharedtoConversationInfo; resilientchannelSectionsdecodingNameCache.swiftchannelPrivateandchannelExtSharedcachesSlackAPIClient.swiftfetchChannelSections()method; removed debug loggingStateStore.swiftgroupBySections()(mentions → explicit → virtual);resolveChannelName()returns(name, isPrivate, isExtShared)tupleSlackStatApp.swiftNSTextAttachment; right-aligned time; section header stylingModelsTests.swiftisPrivate,isExtShared, missing sections decodingStateStoreTests.swiftTest Plan