Skip to content

Implement Google OAuth Integration - #40

Closed
singhaditya21 wants to merge 1 commit into
mainfrom
google-oauth-implementation-5668877588095846487
Closed

Implement Google OAuth Integration#40
singhaditya21 wants to merge 1 commit into
mainfrom
google-oauth-implementation-5668877588095846487

Conversation

@singhaditya21

Copy link
Copy Markdown
Owner

Implemented a complete Google OAuth 2.0 Authorization Code flow for the web demo application.
This replaces the previous simulation with actual integration logic.

Key changes:

  1. Frontend (web-demo):

    • Added Google Identity Services script to index.html.
    • Updated app.js to initialize google.accounts.oauth2.initCodeClient and handle the sign-in flow.
    • Updated api.js to add googleLogin method which calls the backend, bypassing mock data.
  2. Backend (backend/api):

    • Added GOOGLE_CLIENT_ID and GOOGLE_CLIENT_SECRET to config.py.
    • Updated UserCreate schema to support web platform.
    • Added GoogleLoginRequest schema.
    • Implemented POST /api/auth/google endpoint which:
      • Exchanges authorization code for tokens using httpx.
      • Retrieves user info from Google.
      • Finds or creates a user in the database.
      • Returns a JWT access token.

Verification:

  • Verified backend endpoint logic using a Python script (verify_auth.py) that mocked Google API responses and database interactions.
  • Verified frontend integration using a Playwright script (verify_frontend.py) that confirmed the Google Sign-In button triggers the flow and UI updates correctly.

PR created automatically by Jules for task 5668877588095846487 started by @singhaditya21

- Frontend: Update web-demo/js/app.js to use Google Identity Services (GSI) for authorization code flow.
- Frontend: Update web-demo/js/api.js to include googleLogin method and handle forceReal option.
- Frontend: Add GSI script to web-demo/index.html.
- Backend: Add GOOGLE_CLIENT_ID and GOOGLE_CLIENT_SECRET to config.py.
- Backend: Update UserCreate schema to allow 'web' platform and add GoogleLoginRequest schema.
- Backend: Implement POST /api/auth/google endpoint in users.py to exchange code for tokens and create/login user.

Co-authored-by: singhaditya21 <53948039+singhaditya21@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@singhaditya21

Copy link
Copy Markdown
Owner Author

Closing as a duplicate of #41, which implements the same Google OAuth flow and additionally merges cleanly. Consolidating on #41.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant