Implement Apple JWS notification verification - #36
Conversation
- Added `backend/payment-service/src/utils/apple-cert-verifier.js` to handle JWS signature and certificate chain verification. - Added Apple Root CA G3 certificate at `backend/payment-service/src/certs/AppleRootCA-G3.pem`. - Updated `backend/payment-service/src/routes/apple-webhook.js` to use the new verification logic. - Added `backend/payment-service/tests/test-apple-verifier.js` for unit testing the verification logic using self-signed certs. - Verified that the implementation correctly validates chains and signatures. Co-authored-by: singhaditya21 <53948039+singhaditya21@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Reviewed, leaving open. This is the right thing to do — the Apple webhook currently trusts unverified JWS payloads, which is a real security gap. Two notes:
I have not merged it because I cannot exercise the verification path without real Apple notification payloads, and getting signature verification subtly wrong is worse than not having it. |
Implemented cryptographic verification for Apple App Store Server Notifications V2. This includes:
x5cpresence and algorithm (ES256).PR created automatically by Jules for task 15564359096076898345 started by @singhaditya21