Skip to content

Implement AdMob Banner Ad View in Android - #22

Closed
singhaditya21 wants to merge 1 commit into
mainfrom
android-banner-ad-implementation-2062990526689198765
Closed

Implement AdMob Banner Ad View in Android#22
singhaditya21 wants to merge 1 commit into
mainfrom
android-banner-ad-implementation-2062990526689198765

Conversation

@singhaditya21

Copy link
Copy Markdown
Owner

This PR implements the Banner Ad View in the Android application by replacing the mock implementation with the actual Google Mobile Ads SDK integration.

It includes:

  1. Adding the play-services-ads dependency.
  2. Configuring the AndroidManifest.xml with the AdMob Test App ID.
  3. Updating AdManager.kt to initialize the SDK and render the banner ad using AdView within a Jetpack Compose AndroidView.

This fulfills the requirement to replace the mock FrameLayout with the actual AdMob Banner AdView.


PR created automatically by Jules for task 2062990526689198765 started by @singhaditya21

Replaced the mock FrameLayout implementation in `AdManager.kt` with a functional `AdView` using the Google Mobile Ads SDK.

Changes:
- Added `com.google.android.gms:play-services-ads:22.6.0` dependency to `android/app/build.gradle`.
- Added AdMob Application ID (Test ID) to `android/app/src/main/AndroidManifest.xml`.
- Updated `AdManager.kt`:
    - Imported `AdRequest`, `AdSize`, `AdView`, `MobileAds`.
    - Implemented `initialize` using `MobileAds.initialize`.
    - Implemented `BannerAdView` using `AndroidView` wrapping `AdView`.

Co-authored-by: singhaditya21 <53948039+singhaditya21@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@singhaditya21

Copy link
Copy Markdown
Owner Author

Closing as a duplicate of #23, which adds the same AdMob wiring plus interstitials and a newer SDK (23.0.0 vs 22.6.0). Both edit AdManager.kt and add the same APPLICATION_ID meta-data, so they cannot both land. Consolidating on #23.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant