Skip to content

🎨 Palette: Add visual loading states to auth buttons - #196

Open
singhaditya21 wants to merge 1 commit into
mainfrom
palette-add-loading-states-17401746945806951875
Open

🎨 Palette: Add visual loading states to auth buttons#196
singhaditya21 wants to merge 1 commit into
mainfrom
palette-add-loading-states-17401746945806951875

Conversation

@singhaditya21

Copy link
Copy Markdown
Owner

💡 What:
Added visual loading indicators to the Login, Registration, and Google Sign-In buttons. When clicked, the buttons are disabled, their text changes to "⏳ Loading...", and opacity lowers to 0.7.

🎯 Why:
This gives the user immediate visual feedback that their action is processing, which reduces perceived latency and prevents the user from accidentally clicking the button multiple times while the API call is in flight.

📸 Before/After:
(See Playwright screenshot login_loading_state.png for reference, showing the button successfully adapting to loading state).

♿ Accessibility:
The button's disabled attribute is toggled to ensure screen readers announce the element as unavailable while it's processing, and keyboard focus isn't trapped or unnecessarily activated again.


PR created automatically by Jules for task 17401746945806951875 started by @singhaditya21

- Added loading text (`⏳ Loading...`) and disabled visual state (opacity 0.7) to Login, Register, and Google Sign-in buttons upon click/submit
- Handled via `try/finally` block to safely reset the button state regardless of network response
- Pass `e.currentTarget` and `e.submitter` to determine correctly pressed targets

Co-authored-by: singhaditya21 <53948039+singhaditya21@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant