🎨 Palette: Robust loading state for auth form buttons - #195
Conversation
Modifies handleLogin and handleRegister in app.js to utilize e.submitter to target the specific form button clicked. Applies a disabled state, opacity reduction, not-allowed cursor, and loading text (⏳) immediately on submission. The restoration logic is safely wrapped in a try/finally block to guarantee the button unfreezes, even if the API throws an error. Added a UX learning entry to .Jules/palette.md. Co-authored-by: singhaditya21 <53948039+singhaditya21@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What: Added visual loading indicators to the Login and Register form buttons using
e.submitterto handle state directly on the element interacted with. Wrapped the loading tear-down in a robusttry/finallyblock.🎯 Why: To provide immediate feedback that an authentication request is processing, preventing duplicate submissions, and ensuring the UI recovers gracefully if an API error occurs.
📸 Before/After:
Before: Clicking "Sign In with Email" or "Sign Up" showed no visual change on the button itself while the request was in-flight (only a generic toast appeared).
After: The clicked button immediately disables, changes cursor, dims, and displays "⏳ Logging in..." or "⏳ Creating account...", returning to normal once the request completes or fails.
♿ Accessibility: The button is properly set to
disabled=trueand an ARIA-compliantnot-allowedcursor state is utilized during async loading, ensuring screen readers and keyboard navigators understand the form is locked while processing.PR created automatically by Jules for task 2203701536508642651 started by @singhaditya21