Skip to content

Disable sandbox mode for Apple receipts - #15

Open
singhaditya21 wants to merge 1 commit into
mainfrom
fix-subscription-sandbox-13901666695427671407
Open

Disable sandbox mode for Apple receipts#15
singhaditya21 wants to merge 1 commit into
mainfrom
fix-subscription-sandbox-13901666695427671407

Conversation

@singhaditya21

Copy link
Copy Markdown
Owner

Disable sandbox mode for Apple receipt validation.


PR created automatically by Jules for task 13901666695427671407 started by @singhaditya21

This change updates the `activate_subscription` endpoint in `backend/api/app/routers/subscriptions.py` to call `subscription_service.validate_apple_receipt` with `sandbox=False`. This ensures that in the production environment, receipts are validated against the production App Store endpoint rather than the sandbox endpoint.

Testing:
- Verified using a reproduction script `backend/api/reproduce_issue.py` (deleted after verification) which mocked `SubscriptionService` and confirmed the `sandbox` argument is passed as `False`.
- The reproduction script confirmed the fix by asserting `sandbox=False` in the call arguments.

Co-authored-by: singhaditya21 <53948039+singhaditya21@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@singhaditya21

Copy link
Copy Markdown
Owner Author

Leaving open deliberately — correct for release, wrong for right now.

sandbox=True is what makes receipt validation work against Apple's sandbox during development and TestFlight. Flipping it to production before there is a live App Store build would break local and TestFlight testing.

Related: validate_apple_receipt was also sending the literal string your-app-specific-shared-secret as its password, so validation could not have succeeded in either environment. That is fixed on main now (from #18), which makes this switch meaningful when the time comes.

Tracked under Phase 1 in ROADMAP.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant