Set Production API URL - #14
Conversation
Updated the base URL in the release configuration to point to the production API endpoint (https://api.climaai.com). Removed the placeholder comment. This ensures that non-debug builds connect to the correct backend service. Co-authored-by: singhaditya21 <53948039+singhaditya21@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Leaving open deliberately — this is correct, but it should land immediately before a release rather than now. Merging it today points local and CI builds at infrastructure that does not exist yet (there is no deployed API — the Tracked under Phase 1 in ROADMAP.md. |
… R8 rules
Found by installing and running the actual release APK on an emulator, which
had never been done.
The app launched fine, then failed every request with:
Response must include generic type (e.g., Response<String>)
for method ClimaAIApi.getWeather
R8 full mode — the default from AGP 8 — strips generic signatures from types
that are not explicitly kept, and Retrofit reads Response<T> at runtime to build
its call adapters. proguard-rules.pro had the
`kotlin.coroutines.Continuation` keep from Retrofit's official R8 rule set but
not the `retrofit2.Call` and `retrofit2.Response` lines that belong with it, so
only part of the set had been copied in.
This affects minified builds only. Debug builds work, the unit tests pass, lint
is clean and CI is green — none of them exercise R8. The app would have shipped
to Play Store unable to make a single API call.
Verified by rebuilding and reinstalling the release APK: the error is gone, and
the remaining failures are DNS lookups for api.climaai.com, which does not exist
yet (PR #14, deliberately parked until there is a deployed backend).
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
1 participant
Set the production API URL in
ios/ClimaAI/Services/APIClient.swiftby removing the placeholder comment. The URL remainshttps://api.climaai.comas per documentation.PR created automatically by Jules for task 6942908788912635531 started by @singhaditya21