Remove inspecting JSON output when downloading file data#991
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Memory Issue when Downloading File Data
Issue: #990
Python Version(s) Tested: Python 3.14
Operating System(s): Ubuntu 26.04
📝 Summary
Addresses issue where there was a memory leak caused by streaming of all JSON data during download of files.
🔍 Diagnosis
See issue.
🔄 Changes
Removed unused call to
get_json_responseand instead performed response checks on just HTTP status code.✔️ Checklist