fix: map Armenian lowercase ligature ech-yiwn (U+0587) to lowercase 'ev'#215
Open
xianjianlf2 wants to merge 1 commit into
Open
fix: map Armenian lowercase ligature ech-yiwn (U+0587) to lowercase 'ev'#215xianjianlf2 wants to merge 1 commit into
xianjianlf2 wants to merge 1 commit into
Conversation
The Armenian ligature "ech yiwn" (U+0587) is an inherently lowercase
character (its uppercase form is the two-letter "ԵՒ"), but the charMap
transliterated it to uppercase "EV". Every other cased letter in the map
preserves case, so with the default `lower: false` this single entry
silently upper-cased:
slugify("և") // "EV", expected "ev"
Map it to "ev" to match the rest of the map. Adds a regression test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Armenian ligature "ech yiwn" (
և, U+0587) is an inherently lowercase character — its uppercase counterpart is the two-letter sequence "ԵՒ". The charmap transliterated it to uppercase"EV", so with the defaultlower: falseit was silently upper-cased:Every other cased letter in the map preserves case; this was the lone case-violating entry. This PR maps it to
"ev"inconfig/charmap.json(and the generated map inslugify.js) and adds a regression test.Same class of charmap case fix as the merged #209 (Ę, Ī, Ķ, Ū mapped to uppercase to preserve case).
All tests pass: 46 passing (
npm test).