Skip to content

Update Docker builder to Debian Bookworm - #9984

Merged
mergify[bot] merged 3 commits into
sigp:unstablefrom
michaelsproul:fix-docker-debian-security-mirror
Sep 7, 2026
Merged

Update Docker builder to Debian Bookworm#9984
mergify[bot] merged 3 commits into
sigp:unstablefrom
michaelsproul:fix-docker-debian-security-mirror

Conversation

@michaelsproul

Copy link
Copy Markdown
Member

Issue Addressed

Fix failing CI observed here:

Proposed Changes

Keep Rust at 1.88.0 while moving the builder off Bullseye to avoid the failing Debian security package downloads. Update the Ubuntu runtime to 24.04 so its glibc is newer than the builder's.

Keep Rust at 1.88.0 while moving the builder off Bullseye to avoid the failing Debian security package downloads. Update the Ubuntu runtime to 24.04 so its glibc is newer than the builder's.
@michaelsproul michaelsproul added work-in-progress PR is a work-in-progress infra-ci backwards-incompat Backwards-incompatible API change labels Sep 7, 2026
@michaelsproul

michaelsproul commented Sep 7, 2026

Copy link
Copy Markdown
Member Author

This might technically be backwards incompat, if anyone is relying on the specific version of Ubuntu we use in the runner image.

@michaelsproul

Copy link
Copy Markdown
Member Author

Docker builds are still failing, I think we need this.

https://github.com/sigp/lighthouse/actions/runs/34082051165

`lcli/Dockerfile` carries the same bullseye pin as the main `Dockerfile`, so
it breaks the same way now that Debian 11 has reached LTS EOL. Apply the
identical fix: bookworm builder, and Ubuntu 24.04 runtime so its glibc is
newer than the builder's.

Not built by CI (`docker.yml` uses `lcli/Dockerfile.cross`), but broken for
local builds.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Qny4QevtjCbyAyAB7rT7M7

@antondlr antondlr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, thanks!

@mergify

mergify Bot commented Sep 7, 2026

Copy link
Copy Markdown

Queued — the merge queue status continues in this comment ↓.

The reproducible build path still pins `rust:1.88-bullseye` by digest in
three places, and pins exact bullseye package versions. Debian 11 reached
LTS EOL on 2026-08-31, so `apt-get update` in this image fails once the
`bullseye-security` Release file expires.

Bump the per-arch digests to the current `rust:1.88-bookworm` and repin the
build dependencies to their bookworm versions. Rust stays at 1.88.

Verified both pinned images install the pinned packages cleanly:

  amd64  Debian 12, rustc 1.88.0, cmake 3.25.1, glibc 2.36
  arm64  Debian 12, rustc 1.88.0, cmake 3.25.1, glibc 2.36

This also aligns the builder with the `distroless/cc-debian12` runtime,
which previously ran a bullseye-built binary against a bookworm userland.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Qny4QevtjCbyAyAB7rT7M7

@dapplion dapplion left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dapplion dapplion added ready-for-merge This PR is ready to merge. and removed work-in-progress PR is a work-in-progress labels Sep 7, 2026
@mergify

mergify Bot commented Sep 7, 2026

Copy link
Copy Markdown

Merge Queue Status

This pull request spent 25 minutes 30 seconds in the queue, including 22 minutes 32 seconds running CI.

Waiting for
  • check-success=local-testnet-success
  • check-success=test-suite-success
All conditions

Reason

The merge conditions cannot be satisfied due to failing checks

  • test-suite-success

Hint

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio queue comment.

Requeued — the merge queue status continues in this comment ↓.

@mergify mergify Bot added the queued label Sep 7, 2026
@mergify mergify Bot added dequeued and removed queued labels Sep 7, 2026
@dapplion

dapplion commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator

@Mergifyio queue

@mergify

mergify Bot commented Sep 7, 2026

Copy link
Copy Markdown

Merge Queue Status

This pull request spent 29 minutes 29 seconds in the queue, including 28 minutes 5 seconds running CI.

Required conditions to merge

@mergify mergify Bot added queued and removed dequeued labels Sep 7, 2026
@mergify
mergify Bot merged commit 575fe14 into sigp:unstable Sep 7, 2026
38 checks passed
@mergify mergify Bot removed the queued label Sep 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backwards-incompat Backwards-incompatible API change infra-ci ready-for-merge This PR is ready to merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants