Skip to content

disable mplex by default - #9522

Merged
mergify[bot] merged 6 commits into
sigp:unstablefrom
jxs:feat/disable-mplex-by-default
Sep 7, 2026
Merged

disable mplex by default#9522
mergify[bot] merged 6 commits into
sigp:unstablefrom
jxs:feat/disable-mplex-by-default

Conversation

@jxs

@jxs jxs commented Jun 23, 2026

Copy link
Copy Markdown
Member

take 2

@dknopik dknopik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify

mergify Bot commented Jun 23, 2026

Copy link
Copy Markdown

Queued — the merge queue status continues in this comment ↓.

@pawanjay176 pawanjay176 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

Looks good, just need to fix the cli help text and flip the cli test conditions

@michaelsproul michaelsproul added waiting-on-author The reviewer has suggested changes and awaits thier implementation. Networking v8.3.0 Lighthouse release early Q3 2026 labels Jun 24, 2026
@mergify mergify Bot closed this Jul 24, 2026
@mergify

mergify Bot commented Jul 24, 2026

Copy link
Copy Markdown

Hi @jxs, this pull request has been closed automatically due to 30 days of inactivity. If you’d like to continue working on it, feel free to reopen at any time.

@mergify mergify Bot added the stale Stale PRs that have been inactive and is now outdated label Jul 24, 2026
@michaelsproul michaelsproul reopened this Jul 24, 2026
@michaelsproul

Copy link
Copy Markdown
Member

@jxs if you have a sec to fix this up let's get it into unstable

@mergify mergify Bot closed this Aug 23, 2026
@mergify

mergify Bot commented Aug 23, 2026

Copy link
Copy Markdown

Hi @jxs, this pull request has been closed automatically due to 30 days of inactivity. If you’d like to continue working on it, feel free to reopen at any time.

@michaelsproul michaelsproul reopened this Aug 23, 2026
@dknopik dknopik added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Sep 1, 2026
@jxs

jxs commented Sep 7, 2026

Copy link
Copy Markdown
Member Author

let's go!

@jxs jxs added the ready-for-merge This PR is ready to merge. label Sep 7, 2026
@mergify mergify Bot added the queued label Sep 7, 2026
@mergify

mergify Bot commented Sep 7, 2026

Copy link
Copy Markdown

Merge Queue Status

  • Entered queue2026-09-07 11:37 UTC · Rule: default · triggered by rule Add ready-to-merge labeled PRs to merge queue
  • Checks failed · on draft merge queue: checking #9522 on unstable (115bd16) #9985
  • 🚫 Left the queue2026-09-07 11:40 UTC · at 54bd7e4f129af6220ddc883f446cc6acf7c17ee7

This pull request spent 3 minutes 42 seconds in the queue, including 1 minute 42 seconds running CI.

Waiting for
  • check-success=local-testnet-success
  • check-success=test-suite-success
All conditions

Reason

The merge conditions cannot be satisfied due to failing checks

  • local-testnet-success

Hint

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio queue comment.

Requeued — the merge queue status continues in this comment ↓.

@mergify mergify Bot added dequeued and removed queued labels Sep 7, 2026
@jxs

jxs commented Sep 7, 2026

Copy link
Copy Markdown
Member Author

@Mergifyio queue

@mergify

mergify Bot commented Sep 7, 2026

Copy link
Copy Markdown

Merge Queue Status

This pull request spent 2 minutes 37 seconds in the queue, including 1 minute 20 seconds running CI.

Waiting for
  • check-success=local-testnet-success
  • check-success=test-suite-success
All conditions

Reason

The merge conditions cannot be satisfied due to failing checks

  • local-testnet-success

Hint

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio queue comment.

Requeued — the merge queue status continues in this comment ↓.

@mergify mergify Bot added queued and removed dequeued labels Sep 7, 2026
@mergify mergify Bot added dequeued and removed queued labels Sep 7, 2026
@jxs
jxs force-pushed the feat/disable-mplex-by-default branch from 54bd7e4 to b7374db Compare September 7, 2026 16:27
@mergify mergify Bot added queued and removed dequeued labels Sep 7, 2026
@mergify

mergify Bot commented Sep 7, 2026

Copy link
Copy Markdown

Merge Queue Status

  • Entered queue2026-09-07 16:34 UTC · Rule: default · triggered by rule Add ready-to-merge labeled PRs to merge queue
  • Checks passed · on draft merge queue: checking #9522 on unstable (575fe14) #9994
  • Merged2026-09-07 17:04 UTC · at 1256bd99e1b6c5d1290241849354b7e27dbc0ed9 · squash

This pull request spent 29 minutes 39 seconds in the queue, including 27 minutes 39 seconds running CI.

Required conditions to merge

@mergify
mergify Bot merged commit 1256bd9 into sigp:unstable Sep 7, 2026
39 checks passed
@mergify mergify Bot removed the queued label Sep 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Networking ready-for-merge This PR is ready to merge. ready-for-review The code is ready for review stale Stale PRs that have been inactive and is now outdated v8.3.0 Lighthouse release early Q3 2026

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants