fix: storage_flush check thread exists before joining - #554
Open
shikl3x7 wants to merge 1 commit into
Open
Conversation
Author
|
Error observed at client during the storage write gourav@gourav:~/images/lx1/example$ mtda-cli -r 134.86.254.94 storage write isar-image-installer-lx1-x86-uefi.wic
Discovered bmap file 'isar-image-installer-lx1-x86-uefi.wic.bmap'
isar-image-installer-lx1-x86-uefi.wic: [####################] 100% (650 MiB read, 5.70 GiB written, 36 KiB/s)
'storage write' failed! ('NoneType' object has no attribute 'join') |
fmoessbauer
reviewed
Dec 16, 2025
fmoessbauer
approved these changes
Dec 17, 2025
Author
|
@chombourger we checked on latest version also we still see this issue intermittently; this fix is currently applied in all our MTDA. Please review this and suggest :) |
Some issue are observed during storage write, happens when the storage_flush is called by client. At server thread join is tried when flush is called in writer, since the stop has already been called thread for the instance is already reinitialized to none, Due to this the at client we observe errors stating calling join on None type. Tested-by: Gourav Singh <gourav.singh.ext@siemens.com> Signed-off-by: Shivaschandra KL <shivaschandra.k-l@siemens.com>
shikl3x7
force-pushed
the
storage_fix_flush
branch
from
August 10, 2026 14:25
6479c76 to
bb9279c
Compare
Collaborator
|
a flush-after-stop test could easily be added to tests/test_storage.py. this way we get a reproducer (write the test before pulling your fix and then confirm that the issue is gone by running the test again) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some issue are observed during storage write, it happens when the storage_flush is called by client. At server thread join is tried when flush is called to writer, since the stop has already been called thread for the instance is already reinitialized to none, Due to this at client we observe errors stating calling join on None type.
Tested-by: Gourav Singh gourav.singh.ext@siemens.com
Signed-off-by: Shivaschandra KL shivaschandra.k-l@siemens.com