refactor(theme)!: replace legacy shadow variables - #2521
Draft
spike-rabbit wants to merge 1 commit into
Draft
Conversation
Use system shadow tokens directly across Element, Bootstrap compatibility styles, maps, dashboards, and AG Grid. BREAKING CHANGE: Legacy elevation and Bootstrap shadow variables are removed. Remove uses of $element-elevation-1, $element-elevation-2, $element-elevation-3, $element-elevation-4, $element-elevation-inset-1, $element-elevation-inset-2, $element-elevation-inset-3, $element-elevation-inset-4, $box-shadow, $box-shadow-sm, $box-shadow-lg, $box-shadow-inset, $input-box-shadow, $popover-box-shadow, $modal-content-box-shadow-xs, $modal-content-box-shadow-sm-up, and $thumbnail-box-shadow. Replace elevation values with var(--si-sys-effects-shadow-1) through var(--si-sys-effects-shadow-4), or the corresponding $si-sys-effects-shadow-* SCSS system token. The legacy --element-box-shadow-color-1 and --element-box-shadow-color-2 custom properties are also removed.
spike-rabbit
force-pushed
the
refactor/theme-system-shadow-tokens
branch
from
August 6, 2026 18:15
7b2c0c3 to
f1a70a7
Compare
dr-itz
reviewed
Aug 14, 2026
Comment on lines
+81
to
+84
| box-shadow: var(--si-sys-effects-shadow-1); | ||
| box-shadow: var(--si-sys-effects-shadow-2); | ||
| box-shadow: var(--si-sys-effects-shadow-3); | ||
| box-shadow: var(--si-sys-effects-shadow-4); |
Member
There was a problem hiding this comment.
should show the SCSS variable. because that's a compile-time check.
Suggested change
| box-shadow: var(--si-sys-effects-shadow-1); | |
| box-shadow: var(--si-sys-effects-shadow-2); | |
| box-shadow: var(--si-sys-effects-shadow-3); | |
| box-shadow: var(--si-sys-effects-shadow-4); | |
| box-shadow: variables.$si-sys-effects-shadow-1; | |
| box-shadow: variables.$si-sys-effects-shadow-2; | |
| box-shadow: variables.$si-sys-effects-shadow-3; | |
| box-shadow: variables.$si-sys-effects-shadow-4; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace legacy elevation and Bootstrap shadow variables with the
si-sys-effects-shadow-*system tokens. Update shadow consumers across Element, Bootstrap compatibility styles, maps, dashboards, and AG Grid.Breaking change
Removed SCSS variables:
$element-elevation-1,$element-elevation-2,$element-elevation-3,$element-elevation-4$element-elevation-inset-1,$element-elevation-inset-2,$element-elevation-inset-3,$element-elevation-inset-4$box-shadow,$box-shadow-sm,$box-shadow-lg,$box-shadow-inset,$input-box-shadow$popover-box-shadow,$modal-content-box-shadow-xs,$modal-content-box-shadow-sm-up,$thumbnail-box-shadowRemoved CSS custom properties:
--element-box-shadow-color-1--element-box-shadow-color-2Migrate elevation values to
var(--si-sys-effects-shadow-1)throughvar(--si-sys-effects-shadow-4), or the matching$si-sys-effects-shadow-*SCSS token.Validation
pnpm lib:buildpnpm dashboards:buildpnpm maps:buildpnpm run docs:buildgit diff --check