feat(charts): Improve accessibility with keyboard interaction - #1964
feat(charts): Improve accessibility with keyboard interaction#1964akashsonune wants to merge 1 commit into
Conversation
b356d7e to
2edee9c
Compare
There was a problem hiding this comment.
Code Review
This pull request implements accessibility features for charts, including keyboard navigation for data points, zoom sliders, and legends, as well as ARIA support and live announcements. The review feedback identifies several TypeScript style guide violations regarding the use of the any type and suggests improvements for ARIA label redundancy and legend navigation logic.
1778050 to
e3e5eba
Compare
83b4548 to
c311421
Compare
c311421 to
21eb1b1
Compare
21eb1b1 to
790fd7c
Compare
790fd7c to
0f8f511
Compare
aa74c74 to
a222173
Compare
|
@dr-itz can you take a look |
|
@dr-itz can you review |
dr-itz
left a comment
There was a problem hiding this comment.
Examples aren't live any more, so I cannot test. Also, please squash the commits
03935a4 to
f3c0ee2
Compare
6d2bdd3 to
6e5cfbf
Compare
|
@dr-itz I think you should see the examples now. please check |
|
@dr-itz Ping |
spike-rabbit
left a comment
There was a problem hiding this comment.
Is there a reason why we build this ourself? Seems like echarts has some aria modules: https://echarts.apache.org/handbook/en/best-practices/aria
@spike-rabbit The echarts aria modules have some limitations, I had listed the observation under #1973 and the related PR for echarts aria modules- #1735 The echarts aria modules mainly help in third case of charts usage i.e. iterating through all raw data I had a discussion with accessibility team along with @panch1739 and we decided to cover this third case later. There, we can also revisit the echarts aria module and other options to read the raw series data. |
71ebfcf to
d95e9fa
Compare
d95e9fa to
4ef7328
Compare
Escapeto close tooltipShift +/-Shift arrowshometo operate zoom sliderDocumentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: