fix(rtk): use prompt-level Codex guidance without a hook - #620
Open
shunk031 wants to merge 9 commits into
Open
Conversation
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
shunk031
force-pushed
the
fix/rtk-disable-telemetry
branch
from
August 13, 2026 03:44
26f8dae to
bf6660d
Compare
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
shunk031
commented
Aug 13, 2026
shunk031
left a comment
Owner
Author
There was a problem hiding this comment.
鈿狅笍 Performance Alert 鈿狅笍
Possible performance regression was detected for benchmark 'MacOS benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.
| Benchmark suite | Current: c4b0072 | Previous: 4a5ae05 | Ratio |
|---|---|---|---|
zsh average startup time |
0.154 Second |
0.081 Second |
1.90 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @shunk031
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
RTK setup must install the pinned binary and disable telemetry, while Codex integration should follow RTK's official integration contract. Upstream documents Codex support as prompt-level guidance through
AGENTS.md, with no programmatic hook. The custom public Codex hook duplicated that contract and introduced an unnecessary runtime bridge.What Changed
0.42.4in mise and invokeinstall/common/rtk.shfrom the managed run-after template.RTK_TELEMETRY_DISABLED=1on both supported global RTK initialization calls.home/dot_config/codex/AGENTS.mdforrtkprefixes,rtk gain, andrtk proxy.install/common/rtk.shthat Codex uses managedAGENTS.mdguidance instead of a generated@RTK.mdreference or programmatic hook.rtk init --codex; the public managed source remains the authoritative guidance.Validation
Check repository setup and all configured pre-commit checks.
Check shell syntax, shellcheck diagnostics, and repository-style formatting.
bash -n install/common/rtk.sh shellcheck install/common/rtk.sh shfmt --indent 4 --space-redirects --diff .Validate the staged JSON sources and patch formatting.
A direct
initialize_rtksmoke check verified both telemetry-disabled RTK init calls and confirmed that no Codex initialization is invoked.Local Bats was intentionally not run, per repository policy; GitHub Actions provides the Bats validation.