feat(calendar) | expose current SDK options in WordPress SPW-20290 - #77
Open
amir-faghihi wants to merge 1 commit into
Open
feat(calendar) | expose current SDK options in WordPress SPW-20290#77amir-faghihi wants to merge 1 commit into
amir-faghihi wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Functional Changes
Local QA sign-off
Not applicable by Codex (automated checks passed; PHPUnit and live WordPress smoke test were not available)
What is the change?
Why the change is important?
How to test?
npm run test:calendarnode --check plugin/js/showpass-calendar-params.jsphp -l plugin/showpass-wordpress-plugin-shortcode.phpphp -l tests/CalendarShortcodeTest.php[showpass_calendar_widget]and[showpass_embed_calendar]in WordPress with the documented attributes.Database Migrations
What is the reason for the migration(s) and impact on the database?
No database migrations.
Migration Approval
Not applicable by Codex (no migrations).
Additional Notes
PHPUnit was not run because
vendor/bin/phpunitis not installed in the checkout. No deploy notes required.