Add review-pr and review-open-prs skills - #52
Merged
Merged
Conversation
Encode the PR code-review workflow proven on the review round of PRs #43-#51 so it is repeatable: - review-pr: the full single-PR protocol - stacked-base diff scoping, verification-first findings (golden tests, helm unittest, kubeconform, upstream web research), posting one GitHub review with diff-anchored inline comments signed "Claude Agent (CR)", and re-run deduplication. - review-open-prs: a thin orchestrator that fans review-pr out over all open PRs via parallel worktree-isolated agents, then verifies each review landed on the right PR, cleans up the worktrees and produces a cross-PR severity summary. Captures the gotchas hit in practice: shared-scratchpad payload collisions between parallel agents (unique payload filenames + anchor re-verification before POST), 422 on a single bad inline anchor, and PR-branch worktrees not being auto-removed. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds two project skills encoding the PR code-review workflow that was run against PRs #43–#51, so it is repeatable via
/review-pr <N>and/review-open-prs:review-pr— the full single-PR protocol: read repo context first, scope the diff against the PR's (possibly stacked) base, chase PR-specific hypotheses instead of generic scanning, verify every finding (golden tests, helm unittest, kubeconform, upstream web research — never memory), post ONE GitHub review with diff-anchored inline comments and a severity-ranked summary, everything signed— Claude Agent (CR), and dedupe on re-runs.review-open-prs— orchestration only: discovers open PRs and their stack topology, fans out one parallel worktree-isolated agent per PR (each followingreview-pr), then verifies each review landed on the right PR, cleans up the agent worktrees, and produces a cross-PR severity summary. The protocol itself is not duplicated.CLAUDE.md§ Project Skills lists both.Why
The review round on #43–#51 worked well (7 parallel reviews, findings from a
highcert-manager HTTP01 block in #51 down to doc nits) but also hit non-obvious operational pitfalls worth institutionalizing:payload.jsongets overwritten by a sibling between write and POST (manifests as a 422 with the other PR's unresolvable paths/lines) → unique filenames + anchor re-verification right before POST, plus a mandatory post-hoc check that every review landed on the right PR;gh pr diffhunks;Notes
event: COMMENTonly and "never resolve threads" kept consistent with thewatch-prskill.🤖 Generated with Claude Code