Add Claude Code project skills (PR workflow, review watching, chart guidelines) - #46
Merged
Conversation
- prepare-pr: branching, implementation checklist, verification suite, commit/PR conventions and stacked-PR handling - watch-pr: CI watching and the Copilot review triage protocol (including suppressed comments; threads stay open for discussion) - helm-kubernetes-guidelines: chart conventions, hook lifecycle, determinism rules and the template/tooling pitfalls collected while building this package Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
- create-issue: backlog conventions (body structure, labels, linking) - implement-issue: issue lifecycle incl. scope-deviation records and the closing retrospective comment - sync-upstream-deployment: porting changes from the legacy package (survey, mapping table, decision rules, compare-legacy usage) - debug-deploy: failed-deploy diagnosis by phase, log locations, recovery commands and the don'ts (DB migrations don't roll back) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds seven Claude Code project skills to
.claude/skills/so every session (and anyteammate using Claude Code) works with the same conventions instead of re-deriving them:
Workflow
prepare-pr— branching, the implementation checklist (templates + values + schema +tests + golden snapshots + docs in one commit), the full local verification suite,
commit/PR conventions and the stacked-PR pattern.
watch-pr— CI watching, where Copilot feedback lives (thread comments AND suppressedcomments in review bodies), and the triage protocol: fix-or-justify, reply with commit
references, leave threads open for Copilot to respond.
implement-issue— issue lifecycle: triage (incl. comments and related-issueconflicts), recording scope deviations back into the issue, and the closing retrospective
comment (what shipped / what was deliberately dropped and why).
create-issue— backlog conventions: self-contained English bodies(Context/Proposal/Tasks), title prefixes, the label taxonomy, cross-linking rules.
Domain knowledge
helm-kubernetes-guidelines— chart conventions, Helm hook lifecycle rules (unmanagedresources, hook-scoped copies, the scrub pattern), golden determinism rules, Kubernetes
gotchas and Sprig/tooling pitfalls collected while building this package.
sync-upstream-deployment— porting changes from the legacy shopsys/deploymentpackage: upstream survey commands, the legacy→chart mapping table, implement-vs-issue
decision rules and
tools/compare-legacy.shusage.debug-deploy— failed-deploy diagnosis: identifying the phase from end states, loglocations, recovery commands, and the don'ts (DB migrations do not roll back; hook
leftovers are intentional).
CLAUDE.md points to them. No chart/template changes — CI is unaffected.
🤖 Generated with Claude Code