Remove GCloud-specific docker registry support - #29
Merged
Conversation
Drops the GCLOUD_DEPLOY / GCLOUD_CONTAINER_REGISTRY_* branch from the runtime values and all documentation - the feature is unused and was removed upstream as well (shopsys/deployment#77). Only the CI_REGISTRY/DEPLOY_REGISTER_* credentials remain; documented as deviation 18. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
henzigo
force-pushed
the
remove-gcloud-registry
branch
from
August 18, 2026 22:28
336d69b to
56c581c
Compare
There was a problem hiding this comment.
Pull request overview
This PR removes the deprecated GCloud-specific Docker registry credential path (GCLOUD_DEPLOY + GCLOUD_CONTAINER_REGISTRY_*) from the runtime values mapping and cleans up related documentation and test harness environment setup. It aligns the repo with upstream removal (shopsys/deployment#77) while keeping rendered manifests unchanged for the remaining CI_REGISTRY / DEPLOY_REGISTER_* flow.
Changes:
- Removed the GCloud registry branch from
environments/runtime.yaml.gotmpl, leaving only theCI_REGISTRY-based registry mapping. - Removed GCloud references from docs and examples, and documented the removal as a new intentional deviation.
- Dropped an obsolete
unset GCLOUD_DEPLOYfrom the golden test runner.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/run-golden-tests.sh | Removes obsolete GCLOUD_DEPLOY cleanup from the deterministic test env setup. |
| examples/README.md | Updates required CI variables list to remove the GCloud alternative. |
| environments/runtime.yaml.gotmpl | Deletes the GCloud-specific registry mapping branch; retains only CI_REGISTRY mapping. |
| docs/values.md | Updates legacy env-var mapping docs to remove GCLOUD_* references. |
| docs/migrating-from-shopsys-deployment.md | Adds deviation #18 documenting removal of GCloud registry support. |
| deploy/deploy.sh | Updates header comment listing consumed env vars to remove GCloud references. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
The pull secret was already registry-agnostic at the chart level (registry.server/username/password/email); this adds a generic REGISTRY_SERVER/USERNAME/PASSWORD/EMAIL env interface with the GitLab-flavored CI_REGISTRY/DEPLOY_REGISTER_* variables kept as a fallback. GCR/GAR works via username "_json_key" with the service account JSON as the password - documented in the migration guide. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the GCloud-specific docker registry branch (
GCLOUD_DEPLOY+GCLOUD_CONTAINER_REGISTRY_EMAIL/ACCOUNT) and replaces it with a registry-agnosticcredentials interface.
Why
The pull secret template is already generic (
registry.server/username/password/email→dockerconfigjson) — the GCloud branch was just a hardcoded special case of it, removed
upstream as well (shopsys/deployment#77). What remained GitLab-specific were the env var
names, so this PR introduces a generic interface that works with any registry.
Changes
environments/runtime.yaml.gotmpl— genericREGISTRY_SERVER/REGISTRY_USERNAME/REGISTRY_PASSWORD/REGISTRY_EMAILenv vars take precedence; the GitLab-flavoredCI_REGISTRY+DEPLOY_REGISTER_USER/PASSWORDkeep working as a fallback for existingpipelines; the hardcoded GCloud branch is gone
_json_key, password = the serviceaccount JSON (documented in the migration guide and examples)
deploy/deploy.sh,docs/values.md,examples/README.md— documentation updatedtests/run-golden-tests.sh— obsoleteunset GCLOUD_DEPLOYdroppeddocs/original-deployment.mdintentionally still mentions GCloud — it documents the old package)
Rendered manifests are unchanged for the GitLab path (golden snapshots untouched); the
generic path renders the same Secret with the provided server/credentials.
🤖 Generated with Claude Code