Skip to content

[observability] ServiceMonitors, logging annotations and deploy metadata #39

Description

@henzigo

Context

Proposal

  1. Optional ServiceMonitor templates (values-gated monitoring.serviceMonitors.enabled,
    Prometheus Operator prerequisite documented) for redis + rabbitmq exporters; fallback
    prometheus.io/scrape annotations as a second values-gated option for annotation-based
    setups.
  2. Make the logging/enabled annotation a per-component value and revisit the storefront
    default ("false" inherited from legacy — decide consciously).
  3. Deployment metadata annotations rendered from values the wrapper passes through
    (shopsys.com/commit-sha, shopsys.com/pipeline-url, shopsys.com/deployed-at) — pod
    annotations must NOT include per-deploy values that would force needless rollouts; put them
    on the resource metadata only.

Tasks

  • ServiceMonitor templates + values + docs (kubeconform needs the CRD schema or skip)
  • logging/enabled as component value + storefront default decision
  • Deploy metadata annotations + wrapper passthrough
  • Unit tests, golden snapshots

Related: #24 (TTFB probes)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/app-chartshopsys-app chart (workloads, ingresses, secrets, hooks)area/infra-chartshopsys-infra chart (Redis, RabbitMQ, RBAC)enhancementNew feature or requestpriority/low

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions