added Gotenberg service for gift voucher PDF rendering - #83
Open
TomasLudvik wants to merge 4 commits into
Open
Conversation
Runs gotenberg/gotenberg (headless Chromium) as an internal service so the application can render the gift voucher PDF from HTML via sensiolabs/gotenberg-bundle. Adds the Deployment + Service, a GOTENBERG_VERSION variable, and registers them in the migrate-application kustomizations alongside redis/rabbitmq. The app reaches it at http://gotenberg:3000 (GOTENBERG_DSN).
There was a problem hiding this comment.
🟡 Changes recommended
The new GOTENBERG_VERSION defaulting block uses an unsafe -z test pattern that can error when the variable is unset, breaking deployments where the default should apply.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds a Gotenberg (headless Chromium) Kubernetes workload to the deployment package so the application can render gift voucher PDFs from HTML via the internal service endpoint (http://gotenberg:3000).
Changes:
- Add Kubernetes Deployment + Service for
gotenberg. - Register Gotenberg resources in the
migrate-applicationkustomizations (first deploy, first deploy with demo data, continuous deploy). - Introduce
GOTENBERG_VERSIONvariable with a default image value for manifest templating.
File summaries
| File | Description |
|---|---|
| kubernetes/services/gotenberg.yaml | New internal ClusterIP Service exposing Gotenberg on port 3000. |
| kubernetes/deployments/gotenberg.yaml | New Deployment running the Gotenberg container with health probes and resource settings. |
| kubernetes/kustomize/migrate-application/first-deploy/kustomization.yaml | Includes Gotenberg Deployment/Service in first-deploy migration resources. |
| kubernetes/kustomize/migrate-application/first-deploy-with-demo-data/kustomization.yaml | Includes Gotenberg Deployment/Service in demo-data migration resources. |
| kubernetes/kustomize/migrate-application/continuous-deploy/kustomization.yaml | Includes Gotenberg Deployment/Service in continuous-deploy migration resources. |
| deploy/parts/kubernetes-variables.sh | Adds defaulting + templating variable registration for GOTENBERG_VERSION. |
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+16
to
+18
| if [ -z ${GOTENBERG_VERSION} ]; then | ||
| GOTENBERG_VERSION='gotenberg/gotenberg:8' | ||
| fi |
vitek-rostislav
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runs gotenberg/gotenberg (headless Chromium) as an internal service so the application can render the gift voucher PDF from HTML via sensiolabs/gotenberg-bundle. Adds the Deployment + Service, a GOTENBERG_VERSION variable, and registers them in the migrate-application kustomizations alongside redis/rabbitmq. The app reaches it at http://gotenberg:3000 (GOTENBERG_DSN).