Add more books and improve UI/UX - #31
Open
shirshak55 wants to merge 1 commit into
Open
Conversation
shirshak55
commented
Sep 1, 2026
Owner
- add more books
- upgrade deps
- improve things.
There was a problem hiding this comment.
🟡 Changes recommended
The pre-commit ordering can produce HTML that fails format checks, and the search control lacks an accessible name.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Expands the PDF catalog, modernizes generation tooling, and improves site usability.
Changes:
- Expands the catalog to 69 categorized books.
- Adds searchable table UI, PDF sizes, bookmarks, and retry support.
- Upgrades Node.js, pnpm, TypeScript, Playwright, and release automation.
File summaries
| File | Description |
|---|---|
config.toml |
Adds and categorizes books. |
docs/index.html |
Updates the generated website. |
package.json |
Upgrades dependencies and Node.js. |
pnpm-lock.yaml |
Locks upgraded packages. |
pnpm-workspace.yaml |
Configures dependency build permissions. |
readme.md |
Updates usage and requirements. |
src/generate-site.ts |
Generates categorized table rows. |
src/main.ts |
Adds retries, filtering, and bookmarks. |
src/shared/config.ts |
Adds category configuration. |
src/shared/url.ts |
Reformats URL validation. |
src/template.html |
Introduces the redesigned searchable UI. |
tsconfig.json |
Reformats compiler configuration. |
.github/workflows/nodejs.yml |
Updates build and release automation. |
Review details
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
- Files reviewed: 11/13 changed files
- Comments generated: 2
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| "typescript": "^7.0.2" | ||
| }, | ||
| "simple-git-hooks": { | ||
| "pre-commit": "pnpm lint && pnpm format && pnpm knip && node src/generate-site.ts && git add docs/index.html" |
| > | ||
| </header> | ||
| <div class="search-wrap"> | ||
| <input id="search" type="search" placeholder="Search books…" autocomplete="off" /> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.