Skip to content

Add more books and improve UI/UX - #31

Open
shirshak55 wants to merge 1 commit into
mainfrom
changeset123
Open

Add more books and improve UI/UX#31
shirshak55 wants to merge 1 commit into
mainfrom
changeset123

Conversation

@shirshak55

Copy link
Copy Markdown
Owner
  • add more books
  • upgrade deps
  • improve things.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The pre-commit ordering can produce HTML that fails format checks, and the search control lacks an accessible name.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Expands the PDF catalog, modernizes generation tooling, and improves site usability.

Changes:

  • Expands the catalog to 69 categorized books.
  • Adds searchable table UI, PDF sizes, bookmarks, and retry support.
  • Upgrades Node.js, pnpm, TypeScript, Playwright, and release automation.
File summaries
File Description
config.toml Adds and categorizes books.
docs/index.html Updates the generated website.
package.json Upgrades dependencies and Node.js.
pnpm-lock.yaml Locks upgraded packages.
pnpm-workspace.yaml Configures dependency build permissions.
readme.md Updates usage and requirements.
src/generate-site.ts Generates categorized table rows.
src/main.ts Adds retries, filtering, and bookmarks.
src/shared/config.ts Adds category configuration.
src/shared/url.ts Reformats URL validation.
src/template.html Introduces the redesigned searchable UI.
tsconfig.json Reformats compiler configuration.
.github/workflows/nodejs.yml Updates build and release automation.
Review details

Files not reviewed (1)

  • pnpm-lock.yaml: Generated file
  • Files reviewed: 11/13 changed files
  • Comments generated: 2
  • Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread package.json
"typescript": "^7.0.2"
},
"simple-git-hooks": {
"pre-commit": "pnpm lint && pnpm format && pnpm knip && node src/generate-site.ts && git add docs/index.html"
Comment thread src/template.html
>
</header>
<div class="search-wrap">
<input id="search" type="search" placeholder="Search books&hellip;" autocomplete="off" />
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants