Skip to content

Registration V1 cleanup - #293

Merged
NiranjanaBinoy merged 4 commits into
developfrom
ref/registration-v2-cleanup
Jul 22, 2026
Merged

Registration V1 cleanup#293
NiranjanaBinoy merged 4 commits into
developfrom
ref/registration-v2-cleanup

Conversation

@NiranjanaBinoy

@NiranjanaBinoy NiranjanaBinoy commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Pull Request

Description

Changes

  • Removed registration v1 related changes
  • Removed NEXT_PUBLIC_SHINZOHUB_V2_REGISTRATION_FLAG and its usage.
  • Removed Validators list and the form to add validators for devnet, deleted all routes and database related connections and code.
  • Removed dead code and components.
  • Reorganized some files and exports.

Related Issue

fixes #185

Steps to Test

  1. Go to branch preview url
  2. Make sure the landing page is loading correctly and user can submit a generator and host registration without error.

Checklist

  • Code compiles / runs
  • Tests added / updated
  • Documentation updated if needed
  • PR is self-contained and focused
  • Code does not break any existing features
  • Code passes personal internal testing

Notes

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jul 17, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
shinzo-webapp-staging accdb27 Commit Preview URL

Branch Preview URL
Jul 22 2026, 07:45 PM

@NiranjanaBinoy
NiranjanaBinoy requested a review from VanishMax July 17, 2026 05:24
@NiranjanaBinoy NiranjanaBinoy self-assigned this Jul 17, 2026
@VanishMax

Copy link
Copy Markdown
Collaborator

@NiranjanaBinoy I see this UI in the landing page. Was it like this before? Probably lacks empty/loading states in the table

image

@NiranjanaBinoy

Copy link
Copy Markdown
Contributor Author

@NiranjanaBinoy I see this UI in the landing page. Was it like this before? Probably lacks empty/loading states in the table

@VanishMax If the user abandon the registration process after assertion, we will not have the connection string to pull the health data or the DID key, currently we are not filtering them out but displaying them like this.

@VanishMax

Copy link
Copy Markdown
Collaborator

@NiranjanaBinoy would you like to add this as another ticket or resolve the UI here? Happy to approve.

Or we could actually remove the tables from the registration app having the same data in the explorer? What do you think?

@NiranjanaBinoy

Copy link
Copy Markdown
Contributor Author

@VanishMax
I think we should keep the table as we already have that in production and Sonia will be directing the user here for verification after registration.

Is the UI issue you have mentioned is the empty fields? It is because of incomplete registration process - this kind of implies the user have successfully asserted but the registration is not complete, we can add a separate ticket to figure out how to deal with this. I do not wanted to add any changes other than cleaning up to this PR.

@VanishMax VanishMax left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NiranjanaBinoy approving as the UI emptiness isn't about this refactoring. Though, it'd be better to style it in a way that prompts user to register. Empty tooltips don't look that nice.

@NiranjanaBinoy
NiranjanaBinoy force-pushed the ref/registration-v2-cleanup branch from 102551a to accdb27 Compare July 22, 2026 19:41
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jul 22, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
shinzo-explorer-internal accdb27 Commit Preview URL

Branch Preview URL
Jul 22 2026, 07:44 PM

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jul 22, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
faucet-internal accdb27 Commit Preview URL

Branch Preview URL
Jul 22 2026, 07:43 PM

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jul 22, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
shinzo-explorer accdb27 Commit Preview URL

Branch Preview URL
Jul 22 2026, 07:43 PM

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jul 22, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
faucet accdb27 Commit Preview URL

Branch Preview URL
Jul 22 2026, 07:42 PM

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jul 22, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
shinzo-studio accdb27 Commit Preview URL

Branch Preview URL
Jul 22 2026, 07:43 PM

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jul 22, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
shinzo-studio-internal accdb27 Commit Preview URL

Branch Preview URL
Jul 22 2026, 07:43 PM

@NiranjanaBinoy
NiranjanaBinoy changed the base branch from main to develop July 22, 2026 19:41
@NiranjanaBinoy
NiranjanaBinoy merged commit aa296f6 into develop Jul 22, 2026
8 checks passed
@NiranjanaBinoy
NiranjanaBinoy deleted the ref/registration-v2-cleanup branch July 22, 2026 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clean up the NEXT_PUBLIC_SHINZOHUB_V2_REGISTRATION_FLAG feature flag

2 participants