Do not trigger the semicolon_in_expressions_from_macros lint - #560
Merged
Conversation
✅ Deploy Preview for shepmaster-snafu ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
rust-lang/rust#79813 We cannot usefully write a test for this as the lint has historically not been applied to macros from other crates. We only test the `whatever` macro through doctests and integration tests, which count as "other crates" for our purposes. It appears that only recently has the lint been expanded to go across crates, but it's already deny-by-default. In lieu of a test, we can reproduce the error by running `cargo test` with a specific nightly. I used `cargo 1.99.0-nightly (3efb1f477 2026-07-17)`.
shepmaster
force-pushed
the
whatever-semicolon-expression
branch
from
July 21, 2026 17:44
451fa6a to
86c5365
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rust-lang/rust#79813
We cannot usefully write a test for this as the lint has historically not been applied to macros from other crates. We only test the
whatevermacro through doctests and integration tests, which count as "other crates" for our purposes. It appears that only recently has the lint been expanded to go across crates, but it's already deny-by-default.In lieu of a test, we can reproduce the error by running
cargo testwith a specific nightly. I usedcargo 1.99.0-nightly (3efb1f477 2026-07-17).