fix(table-generator): include nested workspaces in the apps table - #34
Open
Dusk1e wants to merge 1 commit into
Open
fix(table-generator): include nested workspaces in the apps table#34Dusk1e wants to merge 1 commit into
Dusk1e wants to merge 1 commit into
Conversation
scanDirectory only looked one level below apps/, so any workspace nested under a grouping directory was skipped. apps/ethereum and apps/solana hold no package.json of their own, so the scan stopped at them and the three apps inside were never listed in the README. Treat a directory without a package.json as a grouping directory and recurse into it. This matches pnpm-workspace.yaml, which already declares apps/solana/* and apps/ethereum/* as workspaces. Directory entries are now sorted so the generated table does not depend on filesystem ordering, and dotfiles and node_modules are skipped while walking. Regenerated README.md now lists all 8 apps instead of 5. Also adds the missing description to the Ethereum example so its new row is not rendered as "No description provided".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scanDirectory only scanned one level under apps so nested workspaces were skipped
apps/ethereum and apps/solana have no package.json of their own so the three apps
inside them never reached the generated README table
Now recurses into directories without a package.json sorts entries for stable
output and skips dotfiles and node_modules
README regenerated lists 8 apps instead of 5
Tests
pnpm update-table finds 8 apps and produces the committed README
pnpm check-table passes and is idempotent after the change
biome check clean on both changed files