fix: pin npm to v11 and bump Node to 22.x to avoid npm@latest engine break - #469
Merged
Merged
Conversation
…break npm published v12.0.0 as "latest", which requires Node ^22.22.2 || ^24.15.0 || >=26. The action provisioned Node 20.x and ran `npm install -g npm@latest`, so every consumer pinned to shannah/jdeploy@master started failing with EBADENGINE the moment npm 12 shipped, with no change on their side. - Pin the upgrade to `npm@11` instead of tracking `npm@latest` so a future npm major with a higher Node engine requirement can't silently break the action again. - Bump Node from 20.x to 22.x, clearing the runner's Node 20 deprecation warning while staying compatible with npm 11's trusted-publishing (OIDC). - Gate the npm upgrade in action.yml on `deploy_target == 'npm'` since trusted publishing is npm-registry-only; GitHub-only releases skip it. Applied the same pin/Node bump to the internal maven.yml release workflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm published v12.0.0 as "latest", which requires Node ^22.22.2 || ^24.15.0
|| >=26. The action provisioned Node 20.x and ran
npm install -g npm@latest,so every consumer pinned to shannah/jdeploy@master started failing with
EBADENGINE the moment npm 12 shipped, with no change on their side.
npm@11instead of trackingnpm@latestso a futurenpm major with a higher Node engine requirement can't silently break the
action again.
warning while staying compatible with npm 11's trusted-publishing (OIDC).
deploy_target == 'npm'sincetrusted publishing is npm-registry-only; GitHub-only releases skip it.
Applied the same pin/Node bump to the internal maven.yml release workflow.