html5ever: Add spec references for the tokenizer steps - #782
Merged
Conversation
simonwuelker
force-pushed
the
spec-steps
branch
from
August 27, 2026 23:02
dbb8268 to
66f04f7
Compare
github-actions
Bot
added
V-non-breaking
simonwuelker
force-pushed
the
spec-steps
branch
from
August 27, 2026 23:40
66f04f7 to
532212b
Compare
github-actions
Bot
added
V-non-breaking
simonwuelker
force-pushed
the
spec-steps
branch
from
August 28, 2026 00:04
532212b to
8bf055a
Compare
Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
simonwuelker
force-pushed
the
spec-steps
branch
from
August 28, 2026 00:09
8bf055a to
31ff7ea
Compare
github-actions
Bot
added
V-non-breaking
mrobinson
approved these changes
Aug 28, 2026
mrobinson
left a comment
mrobinson
left a comment
Member
There was a problem hiding this comment.
Rubber-stamping this one. It seems like an improvement as long as tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our tokenizer code mostly follows the spec directly, but sometimes we deviate. For example, when the specification says to reconsume a character in another state then sometimes we will inline what that state would do, to avoid one iteration of the state machine. This change adds spec text to the code like we do in the
scriptcrate in servo, and adds notes when our code deviates.I've also tried to reorder the match arms of the state machine to match the order that they are listed in the spec, but parts of the code depend on the order of the arms, so its not always possible.