Bug fixed: Close button on each badge was not removing the item. - #64
Open
mohammadazeemwani wants to merge 1 commit into
Open
Bug fixed: Close button on each badge was not removing the item.#64mohammadazeemwani wants to merge 1 commit into
mohammadazeemwani wants to merge 1 commit into
Conversation
Issue: The issue arises from using the latest badge component from shadcn; which has a default behavior to set the pointer-events to none for SVG's. Implementation: Same was fixed by applying to the badge in the multi-select component. Other Ways to solve the same (not-recommended): While there are other ways to solve the same problem, for example, changing the in the badge component itself, but that would most probably break the components that you use from the shadcn itself. So it's wise to change that here.
Contributor
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mohammadazeemwani
marked this pull request as ready for review
July 9, 2025 10:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The issue arises from using the latest badge component from shadcn; which has a default behavior to set the pointer-events to none for SVG's.
Implementation
Same was fixed by applying to the badge in the multi-select component.
Other Ways to solve the problem (not-recommended)
While there are other ways to solve the same problem, for example, changing the in the badge component itself, but that would most probably break the components that you use from the shadcn itself. So it's wise to change that here.