fix: stop swallowing nix output on non-concurrent builds - #393
Merged
Conversation
Problem: `Command::run` goes through `tokio::process::Command::output`, which forces both stdout and stderr to piped regardless of the explicit `Stdio::inherit()` set right before it. So local and single remote host builds (no progress bar) silently captured nix's live build log, including --log-format internal-json output, and discarded it on success, breaking pipes into nix-output-monitor/nom. Solution: Spawn the build command directly and read it back with `Child::wait_with_output`, which only reads the pipes that were actually configured. stdout stays piped for the realised output path, stderr stays inherited so nix's native output streams straight through.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
Command::rungoes throughtokio::process::Command::output, which forces both stdout and stderr to piped regardless of the explicitStdio::inherit()set right before it. So local and single remote host builds (no progress bar) silently captured nix's live build log, including --log-format internal-json output, and discarded it on success, breaking pipes into nix-output-monitor/nom.Solution: Spawn the build command directly and read it back with
Child::wait_with_output, which only reads the pipes that were actually configured. stdout stays piped for the realised output path, stderr stays inherited so nix's native output streams straight through.fixes #386