Skip to content

README: update overlay reference - #392

Closed
panchoh wants to merge 1 commit into
serokell:masterfrom
panchoh:update/readme
Closed

README: update overlay reference#392
panchoh wants to merge 1 commit into
serokell:masterfrom
panchoh:update/readme

Conversation

@panchoh

@panchoh panchoh commented Aug 8, 2026

Copy link
Copy Markdown

Leftover from 6fc0024.

@weriomat

weriomat commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Seems to be a duplicate of #329 and in particular this commit :)

@panchoh

panchoh commented Aug 8, 2026

Copy link
Copy Markdown
Author

Seems to be a duplicate of #329 and in particular this commit :)

Thanks, I hadn’t noticed. Closing…

@panchoh panchoh closed this Aug 8, 2026
@weriomat

weriomat commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Your fine :) , this PR is quite old by now ...

@weriomat

weriomat commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

We could also leave this PR open in hopes of it getting merged quicker ;)
(and I would drop the commit)
However you would like to handle this

@panchoh

panchoh commented Aug 8, 2026

Copy link
Copy Markdown
Author

We could also leave this PR open in hopes of it getting merged quicker ;) (and I would drop the commit) However you would like to handle this

It’s not that critical, and your PR brings lots of goodies, so let’s focus on that one, I think. 👍

@panchoh
panchoh deleted the update/readme branch August 8, 2026 11:07
@weriomat

weriomat commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Oki doki

@panchoh

panchoh commented Aug 17, 2026

Copy link
Copy Markdown
Author

@weriomat, I was thinking that maybe #329 would benefit from being expressed as a set of Stacked PRs, so that upstream can have an easier time reviewing it. Would you be up to try it?

For reference, see:

https://github.blog/changelog/2026-07-30-stacked-pull-requests-are-now-in-public-preview/
https://docs.github.com/en/pull-requests/how-tos/stacked-pull-requests
https://github.com/github/gh-stack
https://www.youtube.com/@GitHub/search?query=stacked%20prs
https://youtu.be/3Z1xcfF2xlY

@weriomat

Copy link
Copy Markdown
Contributor

Thanks, I did not know about stacked PRs. This will not work as the target for the first PR is upstream/master which is another repository (as my master branch is a "soft" fork).This is a known limitation.

@weriomat

Copy link
Copy Markdown
Contributor

I could open individual PRs if you want (for my experiments I have created the branches...)

@panchoh

panchoh commented Aug 18, 2026

Copy link
Copy Markdown
Author

I could open individual PRs if you want (for my experiments I have created the branches...)

I think that the smaller the PRs, the higher the chance of the reviewers to accept them. But remember that I’m just a newcomer here, this is just my humble opinion, due to my experience in other areas of the Nix ecosystem and in general.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants